Mahara

All notifications can be clicked for deletion, but shouldn't be in "Sent"

Bug #1532398 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 16.04.0
15.10
Fix Released
High
Unassigned
Mahara 15.10.2

Bug Description

Mahara 15.10+

Certain messages in the "Sent" box cannot be deleted. However, they can still be selected for deletion. Prior to Mahara 15.10, notifications that could not be deleted, did not have a check box. See http://manual.mahara.org/en/15.04/account/notifications.html#sent

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5905

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5905
Committed: https://git.mahara.org/mahara/mahara/commit/56b4561af0b8abaaf4e92b2c27786b21eca48302
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 56b4561af0b8abaaf4e92b2c27786b21eca48302
Author: Robert Lyon <email address hidden>
Date: Thu Jan 14 12:33:18 2016 +1300

Bug 1532398: Hide the delete checkbox in Sent section of mailbox

For non multi-party notifications as it was in 15.04

1 to 1 communtications should only be able to be deleted by the
recipient and not the sender.

behatnotneeded - should be covered by existing tests

Change-Id: If7c1ebc114566c615add01b41f6f30c1a2bc80f5
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6099

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6099
Committed: https://git.mahara.org/mahara/mahara/commit/595b4271e8329471a25e5dc2c8327a0ee4a12e36
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 595b4271e8329471a25e5dc2c8327a0ee4a12e36
Author: Robert Lyon <email address hidden>
Date: Thu Jan 14 12:33:18 2016 +1300

Bug 1532398: Hide the delete checkbox in Sent section of mailbox

For non multi-party notifications as it was in 15.04

1 to 1 communtications should only be able to be deleted by the
recipient and not the sender.

behatnotneeded - should be covered by existing tests

Change-Id: If7c1ebc114566c615add01b41f6f30c1a2bc80f5
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 56b4561af0b8abaaf4e92b2c27786b21eca48302)

Kristina Hoeppner (kris-hoeppner)
tags: added: usermanualupdate
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.