Tags that are excluded are not highlighted in "Tagged journal entries" tag chooser

Bug #1530613 reported by Kristina Hoeppner on 2016-01-03
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
15.10
High
Unassigned

Bug Description

Mahara 15.10+

When you select the tags to display for a journal in the "Tagged journal entries" block, you can exclude tags. These are supposed to be displayed in a different color, see for Mahara 15.04 http://manual.mahara.org/en/15.04/_images/taggedjournalentries_tags.png

This is not the case in 15.10. All tags have the same color and thus it can't be distinguished which ones are excluded when you choose your tags.

Robert Lyon (robertl-9) wrote :

Ok, there are 2 problem here.

1) the syntax to to do custom templating has changed between v3 and v4 we need to change line 364 in htdocs/artefact/blog/blocktype/taggedposts/lib.php from:

 'extraparams' => array('formatSelection' => "$formatSelection"),

to

'extraparams' => array('templateSelection' => "$formatSelection"),

but there is also a problem in Select2 v4.0.0 where templateSelection doesn't have the 'container' variable now.

This has been fixed in 4.0.1 https://github.com/select2/select2/releases/tag/4.0.1 so we need to upgrade mahara to use 4.0.1 first.

I've made a bug report for that - bug 1533971

Reviewed: https://reviews.mahara.org/5919
Committed: https://git.mahara.org/mahara/mahara/commit/1f9bbefe1ddbada754591eb0503a4f5d628fe4ab
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 1f9bbefe1ddbada754591eb0503a4f5d628fe4ab
Author: Robert Lyon <email address hidden>
Date: Fri Jan 15 14:30:29 2016 +1300

Bug 1530613: Getting excluded tags to work with Select2 4.0.1

behatnotneeded existing tests should be enough

Change-Id: I6316c6301c703353928c9e6210e02cdfc25151a8
Signed-off-by: Robert Lyon <email address hidden>
Signed-off-by: Aaron Wells <email address hidden>

Reviewed: https://reviews.mahara.org/6178
Committed: https://git.mahara.org/mahara/mahara/commit/f5582e9fad7863ea5b188c32e30e2c35b555bff0
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit f5582e9fad7863ea5b188c32e30e2c35b555bff0
Author: Robert Lyon <email address hidden>
Date: Fri Jan 15 14:30:29 2016 +1300

Bug 1530613: Getting excluded tags to work with Select2 4.0.1

behatnotneeded existing tests should be enough

Change-Id: I6316c6301c703353928c9e6210e02cdfc25151a8
Signed-off-by: Robert Lyon <email address hidden>
Signed-off-by: Aaron Wells <email address hidden>
(cherry picked from commit 1f9bbefe1ddbada754591eb0503a4f5d628fe4ab)

Changed in mahara:
status: Fix Committed → Fix Released
no longer affects: mahara/16.04
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers