Internal image slideshow doesn't have "First" and "Last" buttons anymore

Bug #1530606 reported by Kristina Hoeppner on 2016-01-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Liam
15.10
Medium
Unassigned
16.04
Medium
Liam
16.10
Medium
Unassigned

Bug Description

Mahara 15.10+

In Mahara 1.9 we introduced the possibility to jump to the first and last image within an image gallery. See http://manual.mahara.org/en/1.9/blocks/files.html#index-7

This is currently not possible anymore in 15.10+.

Robert Lyon (robertl-9) wrote :

The old gallery slideshow system was controlled by a gallery/js/slideshow.js file but the new way it is controlled by bootstrap (I think)

The old way had the arrows outside of the image space - the new way has them over the top of the images, which you can't see if you have a dark/black image.

Also bootstrap carousel allows for adding link circles, which we might want to go with.

eg:

        <ol class="carousel-indicators">
        {foreach from=$images item=image key=k name=images}
            <li data-target="#slideshow{$instanceid}" data-slide-to="{$k}"></li>
        {/foreach}
        </ol>

Reviewed: https://reviews.mahara.org/6340
Committed: https://git.mahara.org/mahara/mahara/commit/6fa397e3969a91e3cf6b5bb9b50828a824d7b6d7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6fa397e3969a91e3cf6b5bb9b50828a824d7b6d7
Author: Liam Sharpe <email address hidden>
Date: Fri Apr 15 11:56:14 2016 +1200

Added first and last buttons to image gallery slideshow block - Bug #1530606

behatnotneeded

Change-Id: Ic839970344a7b09d742f3f609ef2a80e6ea500af

Reviewed: https://reviews.mahara.org/6361
Committed: https://git.mahara.org/mahara/mahara/commit/d1ebeaabcd53bc91b42dbee9e7316fff70797150
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit d1ebeaabcd53bc91b42dbee9e7316fff70797150
Author: Liam Sharpe <email address hidden>
Date: Fri Apr 15 11:56:14 2016 +1200

Added first and last buttons to image gallery slideshow block - Bug #1530606

behatnotneeded

Change-Id: Ic839970344a7b09d742f3f609ef2a80e6ea500af
(cherry picked from commit 6fa397e3969a91e3cf6b5bb9b50828a824d7b6d7)

Reviewed: https://reviews.mahara.org/6362
Committed: https://git.mahara.org/mahara/mahara/commit/664a31c173522ea5770fd88d05c6997eb2283f3f
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 664a31c173522ea5770fd88d05c6997eb2283f3f
Author: Liam Sharpe <email address hidden>
Date: Fri Apr 15 11:56:14 2016 +1200

Added first and last buttons to image gallery slideshow block - Bug #1530606

behatnotneeded

Change-Id: Ic839970344a7b09d742f3f609ef2a80e6ea500af
(cherry picked from commit 6fa397e3969a91e3cf6b5bb9b50828a824d7b6d7)
(cherry picked from commit d1ebeaabcd53bc91b42dbee9e7316fff70797150)

Reviewed: https://reviews.mahara.org/6396
Committed: https://git.mahara.org/mahara/mahara/commit/0ebe822b3d83f8d76014ca4d16acbe4007746fb3
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 0ebe822b3d83f8d76014ca4d16acbe4007746fb3
Author: Pat Kira <email address hidden>
Date: Tue Apr 26 12:19:38 2016 +1200

Bug 1530606 - Styled First and last button on carousel block

behatnotneeded

Change-Id: If377cc507a3ee524ffe28d72b87c3f906a045812

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6430

Reviewed: https://reviews.mahara.org/6427
Committed: https://git.mahara.org/mahara/mahara/commit/a9ef13ee20d2ed98042c566c5dd72c28546e221c
Submitter: Aaron Wells (<email address hidden>)
Branch: 16.04_STABLE

commit a9ef13ee20d2ed98042c566c5dd72c28546e221c
Author: Pat Kira <email address hidden>
Date: Tue Apr 26 12:19:38 2016 +1200

Bug 1530606 - Styled First and last button on carousel block

behatnotneeded

Change-Id: If377cc507a3ee524ffe28d72b87c3f906a045812
(cherry picked from commit 0ebe822b3d83f8d76014ca4d16acbe4007746fb3)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6430
Committed: https://git.mahara.org/mahara/mahara/commit/5acd0f70c699afc2e3588a278e529cdb1f1ea959
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 5acd0f70c699afc2e3588a278e529cdb1f1ea959
Author: Pat Kira <email address hidden>
Date: Tue Apr 26 12:19:38 2016 +1200

Bug 1530606 - Styled First and last button on carousel block

behatnotneeded

Change-Id: If377cc507a3ee524ffe28d72b87c3f906a045812
(cherry picked from commit 0ebe822b3d83f8d76014ca4d16acbe4007746fb3)

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers