Style the participation report page more nicely

Bug #1529713 reported by Kristina Hoeppner on 2015-12-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Liam
15.10
Medium
Unassigned

Bug Description

Mahara 15.10+

When converting to Bootstrap, we knew there was some more work needed for the participation report in a group. If you don't see it, you can activate it on a group's settings page and would then need a few pages shared with the group, created in a the group and have some comments on them.

What would need to be done (see screenshot)

1. Add the indicator for which column is currently the one that is sorted. We already have that in Administration -> Users -> User search.

2. All columns should be sortable, but it doesn't work properly for me. I could only get the first column under "Pages shared with this group" to sort and that sorted also "Pages owned by this group".

3. The page in questions should just be displayed in regular font and font size instead of a heading. This is a report only.

4. The cells for page titles, owners and people who commented should be top-aligned within their row.

5. It would be good to have lines between the individual rows as we have in other tables.

summary: - Style the paricipation report page more nicely
+ Style the participation report page more nicely
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5968

Liam (liam-sharpe) wrote :

Above patch is incorrect. Had a slight mess-up with git, actual patch can be found at: https://reviews.mahara.org/#/c/5968/

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5986

Reviewed: https://reviews.mahara.org/5968
Committed: https://git.mahara.org/mahara/mahara/commit/f86ac83085240862f8a48c1d45b9a440fe14934f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f86ac83085240862f8a48c1d45b9a440fe14934f
Author: Liam Sharpe <email address hidden>
Date: Wed Jan 27 09:13:25 2016 +1300

Styled the participation report page - Bug #1529713

NOTE: Does not include the fix for:
"2. All columns should be sortable, but it doesn't
work properly for me. I could only get the first column
under "Pages shared with this group" to sort and that
sorted also "Pages owned by this group"."

behatnotneeded

Change-Id: If043d94dab3d52fea7c8d1e70910d6e5bd45a41b

Robert Lyon (robertl-9) wrote :

Adding a partial fix for point 2 "All columns should be sortable" - now all columns can be sorted.

The sorting still effects both tables of data but that is ok I recon. If not then a patch to fix that will need the sort to be labelled differently for the 2nd table and have the links keep note of both table's sort settings.

I think it's OK to keep the sorting of both tables at the same time for the time being.

Reviewed: https://reviews.mahara.org/5986
Committed: https://git.mahara.org/mahara/mahara/commit/076e2d93e24f4056e260ab8d097f22605e8feb2e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 076e2d93e24f4056e260ab8d097f22605e8feb2e
Author: Liam Sharpe <email address hidden>
Date: Mon Feb 1 10:46:03 2016 +1300

Removed striped lines and bullet points from lists - Bug #1529713

behatnotneeded

Change-Id: Ieea780e3903290576ccee47c627a1fea8de4164b

Reviewed: https://reviews.mahara.org/5996
Committed: https://git.mahara.org/mahara/mahara/commit/83a2297142c8ae76572cdfefe28f37abe3f3ba2e
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 83a2297142c8ae76572cdfefe28f37abe3f3ba2e
Author: Liam Sharpe <email address hidden>
Date: Mon Feb 1 10:46:03 2016 +1300

Removed striped lines and bullet points from lists - Bug #1529713

behatnotneeded

Change-Id: Ieea780e3903290576ccee47c627a1fea8de4164b
(cherry picked from commit 076e2d93e24f4056e260ab8d097f22605e8feb2e)

tags: added: usermanualupdate
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5992
Committed: https://git.mahara.org/mahara/mahara/commit/4fc56f2e7a669b1de241dea0854febc94a90ba23
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4fc56f2e7a669b1de241dea0854febc94a90ba23
Author: Robert Lyon <email address hidden>
Date: Tue Feb 2 10:20:21 2016 +1300

Bug 1529713: Adjusting the group participation sorting

For the non-title columns

behatnotneeded

Change-Id: I6bce5acf674ca02392300738f152d5f653bfa0e6
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6067

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6068

Reviewed: https://reviews.mahara.org/6068
Committed: https://git.mahara.org/mahara/mahara/commit/12a5d9d056700062ad5f3c64f5848604ff12db9e
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 12a5d9d056700062ad5f3c64f5848604ff12db9e
Author: Robert Lyon <email address hidden>
Date: Tue Feb 2 10:20:21 2016 +1300

Bug 1529713: Adjusting the group participation sorting

For the non-title columns

behatnotneeded

Change-Id: I6bce5acf674ca02392300738f152d5f653bfa0e6
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6067
Committed: https://git.mahara.org/mahara/mahara/commit/b17def92cc2049d12fa3e6815ec8efde88b20bd4
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit b17def92cc2049d12fa3e6815ec8efde88b20bd4
Author: Liam Sharpe <email address hidden>
Date: Wed Jan 27 09:13:25 2016 +1300

Styled the participation report page - Bug #1529713

NOTE: Does not include the fix for:
"2. All columns should be sortable, but it doesn't
work properly for me. I could only get the first column
under "Pages shared with this group" to sort and that
sorted also "Pages owned by this group"."

behatnotneeded

Change-Id: If043d94dab3d52fea7c8d1e70910d6e5bd45a41b

no longer affects: mahara/16.04
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers