Speed up minaccept by only linting changed files
Bug #1524601 reported by
Aaron Wells
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Unassigned | ||
1.10 |
Fix Released
|
Low
|
Unassigned | ||
15.04 |
Fix Released
|
Low
|
Unassigned | ||
15.10 |
Fix Released
|
Low
|
Unassigned |
Bug Description
"make push" takes a long time to finish on my computer. On my laptop at home, just one small change takes about 48 seconds to run through minaccept. I've found myself more frequently just doing "git push gerrit HEAD:refs/
So, I decided to see if I could speed things up. And it seems the biggest use of time in the minaccept is that it runs "php -l" on every PHP file in htdocs, not just the ones that have changed. Same for xmllint on all the XML files, but that's not as big of a problem because there aren't as many of them.
tags: | added: backend makefile minaccept performance |
no longer affects: | mahara/16.04 |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Patch for "master" branch: https:/ /reviews. mahara. org/5842