Speed up minaccept by only linting changed files
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Mahara |
Low
|
Unassigned | ||
| 1.10 |
Low
|
Unassigned | ||
| 15.04 |
Low
|
Unassigned | ||
| 15.10 |
Low
|
Unassigned |
Bug Description
"make push" takes a long time to finish on my computer. On my laptop at home, just one small change takes about 48 seconds to run through minaccept. I've found myself more frequently just doing "git push gerrit HEAD:refs/
So, I decided to see if I could speed things up. And it seems the biggest use of time in the minaccept is that it runs "php -l" on every PHP file in htdocs, not just the ones that have changed. Same for xmllint on all the XML files, but that's not as big of a problem because there aren't as many of them.
tags: | added: backend makefile minaccept performance |
Reviewed: https:/
Committed: https:/
Submitter: Robert Lyon (<email address hidden>)
Branch: master
commit 9f357637d773c3a
Author: Aaron Wells <email address hidden>
Date: Thu Dec 10 17:59:34 2015 +1300
minaccept: Syntax-checker on changed files only (Bug 1524601)
behatnotneeded: Not a change to Mahara's front end
Change-Id: I379b2192c35186
Patch for "15.10_STABLE" branch: https:/
Mahara Bot (dev-mahara) wrote : | #4 |
Patch for "15.04_STABLE" branch: https:/
Reviewed: https:/
Committed: https:/
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.04_STABLE
commit eebc7f1a252072a
Author: Aaron Wells <email address hidden>
Date: Thu Dec 10 17:59:34 2015 +1300
minaccept: Syntax-checker on changed files only (Bug 1524601)
behatnotneeded: Not a change to Mahara's front end
Change-Id: I379b2192c35186
(cherry picked from commit 9f357637d773c3a
Mahara Bot (dev-mahara) wrote : | #6 |
Reviewed: https:/
Committed: https:/
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE
commit f7ad272deaf4f89
Author: Aaron Wells <email address hidden>
Date: Thu Dec 10 17:59:34 2015 +1300
minaccept: Syntax-checker on changed files only (Bug 1524601)
behatnotneeded: Not a change to Mahara's front end
Change-Id: I379b2192c35186
(cherry picked from commit 9f357637d773c3a
Patch for "1.10_STABLE" branch: https:/
Reviewed: https:/
Committed: https:/
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE
commit 3a32d3a9265a05c
Author: Aaron Wells <email address hidden>
Date: Thu Dec 10 17:59:34 2015 +1300
minaccept: Syntax-checker on changed files only (Bug 1524601)
behatnotneeded: Not a change to Mahara's front end
Change-Id: I379b2192c35186
no longer affects: | mahara/16.04 |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/5842