Speed up minaccept by only linting changed files

Bug #1524601 reported by Aaron Wells on 2015-12-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Unassigned
1.10
Low
Unassigned
15.04
Low
Unassigned
15.10
Low
Unassigned

Bug Description

"make push" takes a long time to finish on my computer. On my laptop at home, just one small change takes about 48 seconds to run through minaccept. I've found myself more frequently just doing "git push gerrit HEAD:refs/publish/master" rather than waiting for it to finish.

So, I decided to see if I could speed things up. And it seems the biggest use of time in the minaccept is that it runs "php -l" on every PHP file in htdocs, not just the ones that have changed. Same for xmllint on all the XML files, but that's not as big of a problem because there aren't as many of them.

Aaron Wells (u-aaronw) on 2015-12-10
tags: added: backend makefile minaccept performance

Reviewed: https://reviews.mahara.org/5842
Committed: https://git.mahara.org/mahara/mahara/commit/9f357637d773c3a239f3ce7e9f9a1bd6bc92ee5b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9f357637d773c3a239f3ce7e9f9a1bd6bc92ee5b
Author: Aaron Wells <email address hidden>
Date: Thu Dec 10 17:59:34 2015 +1300

minaccept: Syntax-checker on changed files only (Bug 1524601)

behatnotneeded: Not a change to Mahara's front end

Change-Id: I379b2192c3518690ee1d39c0997b599d9dc91f7a

Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5845

Reviewed: https://reviews.mahara.org/5845
Committed: https://git.mahara.org/mahara/mahara/commit/eebc7f1a252072a0ba58b06d723830da959589d4
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.04_STABLE

commit eebc7f1a252072a0ba58b06d723830da959589d4
Author: Aaron Wells <email address hidden>
Date: Thu Dec 10 17:59:34 2015 +1300

minaccept: Syntax-checker on changed files only (Bug 1524601)

behatnotneeded: Not a change to Mahara's front end

Change-Id: I379b2192c3518690ee1d39c0997b599d9dc91f7a
(cherry picked from commit 9f357637d773c3a239f3ce7e9f9a1bd6bc92ee5b)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5844
Committed: https://git.mahara.org/mahara/mahara/commit/f7ad272deaf4f892f0a9e9b21b23a4db91358dca
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE

commit f7ad272deaf4f892f0a9e9b21b23a4db91358dca
Author: Aaron Wells <email address hidden>
Date: Thu Dec 10 17:59:34 2015 +1300

minaccept: Syntax-checker on changed files only (Bug 1524601)

behatnotneeded: Not a change to Mahara's front end

Change-Id: I379b2192c3518690ee1d39c0997b599d9dc91f7a
(cherry picked from commit 9f357637d773c3a239f3ce7e9f9a1bd6bc92ee5b)

Reviewed: https://reviews.mahara.org/5846
Committed: https://git.mahara.org/mahara/mahara/commit/3a32d3a9265a05c883f0e89361d1a7cd9df59567
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 3a32d3a9265a05c883f0e89361d1a7cd9df59567
Author: Aaron Wells <email address hidden>
Date: Thu Dec 10 17:59:34 2015 +1300

minaccept: Syntax-checker on changed files only (Bug 1524601)

behatnotneeded: Not a change to Mahara's front end

Change-Id: I379b2192c3518690ee1d39c0997b599d9dc91f7a

no longer affects: mahara/16.04
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers