Sorting blocks in column not working correctly

Bug #1523719 reported by Robert Lyon on 2015-12-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Robert Lyon
1.10
Medium
Robert Lyon
15.04
Medium
Robert Lyon
15.10
Medium
Robert Lyon

Bug Description

If I have a column with 6 blocks in them labelled from top to bottom 1 to 6 and I move the block numbered 2 to the position between 5 and 6 I expect block 2 to now be in position 5. But if I refresh the page the block is in position 4.

Things look to work fine when I move a block up/down one position or to the first/last positions though.

Robert Lyon (robertl-9) on 2015-12-08
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 16.04.0
Robert Lyon (robertl-9) wrote :

Some more info:

Eg if you have blocks stacked like this:

Alpha
Beta
Charlie
Delta
Echo
Foxtrox

And you move/drop "Beta" between "Echo" and "Foxtrox" you get this:
Screen state | Database state
--------------------+----------------
Alpha | Alpha
Charlie | Charlie
Delta | Delta
Echo | Beta
Beta | Echo
Foxtrox | Foxtrot

You expect "Beta" to now be in the 5th position, and it is on the screen, but instead it's in the "4th" position in the database

Reviewed: https://reviews.mahara.org/5825
Committed: https://git.mahara.org/mahara/mahara/commit/a8750346a3f671847c9c6e54e61466d0382fde41
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit a8750346a3f671847c9c6e54e61466d0382fde41
Author: Robert Lyon <email address hidden>
Date: Tue Dec 8 12:59:01 2015 +1300

Bug 1523719: Allowing blocks to order right

When moving them downwards in a column from a non-first position to a
non-last position with a jump greater than one place

behatnotneeded

Change-Id: Ie9bacc4a1a4ef77efd4e481c9ab3713885821dc1
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) on 2015-12-17
Changed in mahara:
status: In Progress → Fix Committed
Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5859

Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5860

Reviewed: https://reviews.mahara.org/5860
Committed: https://git.mahara.org/mahara/mahara/commit/eae645a9b880078ab92032f0336f91f350dfaff6
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit eae645a9b880078ab92032f0336f91f350dfaff6
Author: Robert Lyon <email address hidden>
Date: Tue Dec 8 12:59:01 2015 +1300

Bug 1523719: Allowing blocks to order right

When moving them downwards in a column from a non-first position to a
non-last position with a jump greater than one place

behatnotneeded

Change-Id: Ie9bacc4a1a4ef77efd4e481c9ab3713885821dc1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit a8750346a3f671847c9c6e54e61466d0382fde41)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5859
Committed: https://git.mahara.org/mahara/mahara/commit/6e84c9510e7071787535389bfe640b05a435d855
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 6e84c9510e7071787535389bfe640b05a435d855
Author: Robert Lyon <email address hidden>
Date: Tue Dec 8 12:59:01 2015 +1300

Bug 1523719: Allowing blocks to order right

When moving them downwards in a column from a non-first position to a
non-last position with a jump greater than one place

behatnotneeded

Change-Id: Ie9bacc4a1a4ef77efd4e481c9ab3713885821dc1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit a8750346a3f671847c9c6e54e61466d0382fde41)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5858
Committed: https://git.mahara.org/mahara/mahara/commit/f634b2e8bc8c79875a2d177d5e9632f52042c21b
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit f634b2e8bc8c79875a2d177d5e9632f52042c21b
Author: Robert Lyon <email address hidden>
Date: Tue Dec 8 12:59:01 2015 +1300

Bug 1523719: Allowing blocks to order right

When moving them downwards in a column from a non-first position to a
non-last position with a jump greater than one place

behatnotneeded

Change-Id: Ie9bacc4a1a4ef77efd4e481c9ab3713885821dc1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit a8750346a3f671847c9c6e54e61466d0382fde41)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers