Embedded image in "Profile information" block's per-block introduction field, doesn't show after page is shared

Bug #1512897 reported by Aaron Wells on 2015-11-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
15.04
High
Unassigned
15.10
High
Unassigned

Bug Description

This bug deals with a relatively obscure feature, which is the "Introduction" field of the "Profile information" block type. This is an optional wysiwyg text field that you can use to add an intro to the profile info displayed by the block. If filled in, it will be displayed instead of the "Introduction" artefact which is part of your Profile information artefacts. It's a bit confusing because they are both called "Introduction". This bug deals with the block config "introduction", *not* the artefact "introduction".

To replicate:

1. Put a "Profile information" block in a page
2. In the block config, there's an "Introduction" text field. Embed an image there using the TinyMCE image plugin
3. Save the block config
4. Share the page with the Public
5. Log out
6. View the page

Expected result: You should see the embedded image in the block
Actual result: You see the alt text with the name of the image file

I suspect the problem here is that this field is populating neither the view_artefact or nor the artefact_file_embedded tables.

Aaron Wells (u-aaronw) wrote :

High priority because it's a bug that would be visible to end-users, and though the functionality is obscure, it's not buried that deeply.

Aaron Wells (u-aaronw) wrote :

And whatever fix we implement will probably need to get replicated in the Leap2a import/export process too.

Reviewed: https://reviews.mahara.org/5674
Committed: https://git.mahara.org/mahara/mahara/commit/26deb57d76089ed6bdbb2863253b15c871b83f83
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 26deb57d76089ed6bdbb2863253b15c871b83f83
Author: Robert Lyon <email address hidden>
Date: Mon Nov 9 11:26:13 2015 +1300

Bug 1512897: Allowing introtext blocktype to record embedded image data

behatnotneeded: it deals with whether an image shows or not

Change-Id: I3625f9d9948fd3c67f60657fbd3bc67644ae76e7
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/5684

Reviewed: https://reviews.mahara.org/5684
Committed: https://git.mahara.org/mahara/mahara/commit/44e6a263a7d978feb6dba89ba81c5f186dbff3c7
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 44e6a263a7d978feb6dba89ba81c5f186dbff3c7
Author: Robert Lyon <email address hidden>
Date: Mon Nov 9 11:26:13 2015 +1300

Bug 1512897: Allowing introtext blocktype to record embedded image data

behatnotneeded: it deals with whether an image shows or not

Change-Id: I3625f9d9948fd3c67f60657fbd3bc67644ae76e7
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 26deb57d76089ed6bdbb2863253b15c871b83f83)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5683
Committed: https://git.mahara.org/mahara/mahara/commit/082f71583473dcb8be0a3bf3ad241fb7f3431d72
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 082f71583473dcb8be0a3bf3ad241fb7f3431d72
Author: Robert Lyon <email address hidden>
Date: Mon Nov 9 11:26:13 2015 +1300

Bug 1512897: Allowing introtext blocktype to record embedded image data

behatnotneeded: it deals with whether an image shows or not

Change-Id: I3625f9d9948fd3c67f60657fbd3bc67644ae76e7
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 26deb57d76089ed6bdbb2863253b15c871b83f83)

no longer affects: mahara/16.04
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers