Fatal error in threaded comments sortorder upgrade script

Bug #1508301 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Critical
Unassigned
16.04
Fix Released
Critical
Unassigned

Bug Description

The upgrade script for Bug 1499122 causes some fatal errors during upgrade.

Tags: regression
Aaron Wells (u-aaronw)
summary: - Fatal error in threaded artefact sortorder upgrade script
+ Fatal error in threaded comments sortorder upgrade script
Changed in mahara:
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5571

Revision history for this message
Aaron Wells (u-aaronw) wrote :

patch for 15.10_STABLE: https://reviews.mahara.org/#/c/5568/

tags: added: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5568
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/acfa725937c99b586a0fc31fc3e5523f6549b647
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit acfa725937c99b586a0fc31fc3e5523f6549b647
Author: Son Nguyen <email address hidden>
Date: Wed Oct 21 12:23:15 2015 +1300

Fix sorting threaded comments. Bug 1499122

- Add new column 'threadedposition' to table artefact_comment_comment
- Update the column for existing comments
- Calculate the position for new comments
- Display threaded commented using this for correct order
- Add a behat test
- Fix problems in upgrade script (Bug 1508301)

Change-Id: I607f26fccccee8f761754a41a21c6f58dd74cfb6

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5571
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/7519e33169da85457e01fdc0d0462430ffbbe287
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 7519e33169da85457e01fdc0d0462430ffbbe287
Author: Aaron Wells <email address hidden>
Date: Wed Oct 21 17:19:31 2015 +1300

Bug 1508301: Fixing errors in threaded comment upgrade script.

behatnotneeded

Change-Id: I8dab454d81618c2b9aff92f2228ee16b5894ae53

no longer affects: mahara/15.10
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.