The setting 'maxuploadsize' did not count

Bug #1495676 reported by Son Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Son Nguyen
1.10
Fix Released
Medium
Unassigned
1.9
Fix Released
Medium
Unassigned
15.04
Fix Released
Medium
Unassigned
15.10
Fix Released
Undecided
Unassigned

Bug Description

Version: master(15.10), 15.04

In Mahara, the setting $cfg->maxuploadsize can be set to limit the maximum size for one upload. However, this value did not use to calculate the value of "Maximum upload size" to show in htdocs/artefact/file/index.php.

Steps
1. Assume that the postmaxsize value in php setting is 32MB, quota is 50MB and there is no file in the user file area, set the value of $cfg->maxuploadsize to 16MB (16777216)
2. Login as the user, open file browser (htdocs/artefact/file/index.php)

Expected result:
 - The value of "Maximum upload size" should be 16MB
Actual:
 - The value is 32MB

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/5277

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5277
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/dfad9b3ab22918e94ed429a4eb66091fc9cfd4f4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit dfad9b3ab22918e94ed429a4eb66091fc9cfd4f4
Author: Son Nguyen <email address hidden>
Date: Mon Jul 13 11:11:53 2015 +1200

Take into account the mahara setting 'maxuploadsize'. Bug 1495676

behatnotneeded

Change-Id: Icca153ae8d4728ff840bc088d719affb3b80a68f

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/5425

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5426

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/5427
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4503a05085aca330b6c87302c5e985829e7b07f8
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit 4503a05085aca330b6c87302c5e985829e7b07f8
Author: Son Nguyen <email address hidden>
Date: Mon Jul 13 11:11:53 2015 +1200

Take into account the mahara setting 'maxuploadsize'. Bug 1495676

behatnotneeded

Change-Id: Icca153ae8d4728ff840bc088d719affb3b80a68f

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5426
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/dc0695faf66ec84566c62dd538ff3d0d0ff670ed
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit dc0695faf66ec84566c62dd538ff3d0d0ff670ed
Author: Son Nguyen <email address hidden>
Date: Mon Jul 13 11:11:53 2015 +1200

Take into account the mahara setting 'maxuploadsize'. Bug 1495676

behatnotneeded

Change-Id: Icca153ae8d4728ff840bc088d719affb3b80a68f

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5425
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/4037ee1f050adf22c5b5b87adc9520364f2ee165
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 4037ee1f050adf22c5b5b87adc9520364f2ee165
Author: Son Nguyen <email address hidden>
Date: Mon Jul 13 11:11:53 2015 +1200

Take into account the mahara setting 'maxuploadsize'. Bug 1495676

behatnotneeded

Change-Id: Icca153ae8d4728ff840bc088d719affb3b80a68f

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.