Remove compiled CSS from git repository
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Aaron Wells | ||
15.10 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
With Bug 1465107, the CSS in the core themes is now actually compiled from a series of SASS files.
When we initially started on this, I made the decision to keep the compiled CSS in the git repository because I thought it would make life easier for our low-tech folks, because they wouldn't have to compile the CSS themselves in order to get Mahara to run. And it has had this result, but it has also caused immense problems for us devs because every time we make a commit that touches one of the SCSS files, it gets a merge conflict and cannot be merged cleanly into Gerrit.
Best practice with build products is to exclude them from the gerrit repository, and now I'm starting to understand why. ;) So we've decided to go ahead and remove the compiled CSS from the gerrit repo. But we still want to try to make it easy for people to run Mahara from git, without having to understand much about SASS.
So the plan is:
1. Add the compiled CSS to the .gitignore file and remove it from the repo.
2. Add a step to Mahara's makefile, which does everything necessary to build the CSS.
3. Set up the Jenkins test server to build the CSS before it runs its tests.
4. Add the build CSS step to the deployment scripts (so that the Mahara zip files for download will still contain compiled CSS)
5. For people who can't get the CSS build steps to work locally, we set up a web service on one of our servers, which allows you to download the compiled CSS for a given Mahara commit from Gerrit. Something like https:/
6. We add another build step to Mahara's makefile, which detects the current commit, downloads the compiled CSS from the server, and puts it in the right place
Changed in mahara: | |
milestone: | none → 15.10.0 |
status: | New → In Progress |
assignee: | nobody → Aaron Wells (u-aaronw) |
importance: | Undecided → High |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Reviewed: https:/ /reviews. mahara. org/5170 /git.nzoss. org.nz/ mahara/ mahara/ commit/ 5687f2245f6f2ee ab98ac35a41643c 79743aa8af
Committed: https:/
Submitter: Aaron Wells (<email address hidden>)
Branch: master
commit 5687f2245f6f2ee ab98ac35a41643c 79743aa8af
Author: Aaron Wells <email address hidden>
Date: Tue Sep 15 14:27:34 2015 +1200
Bug 1495364: Remove compiled CSS from repo
Devs will now need to compile the CSS themeselves.
Added a "make css" step to the Makefile for this.
behatnotneeded
Change-Id: If1e85674e46e3c 40dd861c8dd240c 93735639fc6