Full copy of blog block with embedded images still causing problems

Bug #1489274 reported by Aaron Wells on 2015-08-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Aaron Wells
15.04
Medium
Aaron Wells
15.10
Medium
Aaron Wells
16.04
Medium
Aaron Wells
16.10
Medium
Unassigned

Bug Description

Bug 1476059 fixed some problems with copies of blogs that have embedded images. But, it didn't do a database update, so blog entries created before that bug fix will still cause problems.

Here's how to replicate:

1. Install Mahara 15.04.2
2. Create a blog entry.
3. Use the TinyMCE "image" button to embed an image in the blog entry
4. Create a page
5. Put a blog entry block on the page.
6. Select the blog entry you created
7. Set the block's copy permission to "Others will get their own copy of your journal"
8. Share the page with registered users
9. Set the page to allow copying
10. Upgrade site to Mahara 15.04.3
11. Log in as a second user
12. Copy the page

Expected result: You should see the image from the blog entry, on your copy of the page
Actual result: The blog entry shows "undefined" where the image should be

Aaron Wells (u-aaronw) on 2015-08-27
tags: added: blog copying images
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/6681

Aaron Wells (u-aaronw) wrote :

I just tested this one in Mahara 16.04_STABLE and found that it's still an issue.

Reviewed: https://reviews.mahara.org/6681
Committed: https://git.mahara.org/mahara/mahara/commit/4ff6350b57dd57cb28968c54fec971488448226a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4ff6350b57dd57cb28968c54fec971488448226a
Author: Aaron Wells <email address hidden>
Date: Wed Aug 26 18:32:52 2015 +1200

Fixing issues in embedded images in copied pages

Bug 1489274
- DB upgrade to fill in artefact_file_embedded records for
existing blog entries
- Improving the regex that rewrites links in copied journal
entries, notes, and text blocks

behatnotneeded: Requires upgrading the site; not testable via Behat

Change-Id: Ie5d5dc12065ed039df663910e5ee738d57377a91

Mahara Bot (dev-mahara) wrote :

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6722

Reviewed: https://reviews.mahara.org/6722
Committed: https://git.mahara.org/mahara/mahara/commit/a5f46a4d003199316cb94660eb41417f8e50f407
Submitter: Aaron Wells (<email address hidden>)
Branch: 16.04_STABLE

commit a5f46a4d003199316cb94660eb41417f8e50f407
Author: Aaron Wells <email address hidden>
Date: Wed Aug 26 18:32:52 2015 +1200

Fixing issues in embedded images in copied pages

Bug 1489274
- DB upgrade to fill in artefact_file_embedded records for
existing blog entries
- Improving the regex that rewrites links in copied journal
entries, notes, and text blocks

behatnotneeded: Requires upgrading the site; not testable via Behat

Change-Id: Ie5d5dc12065ed039df663910e5ee738d57377a91

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6721
Committed: https://git.mahara.org/mahara/mahara/commit/cfee1186da567697b5656924f6b13aeac06fe4b8
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.10_STABLE

commit cfee1186da567697b5656924f6b13aeac06fe4b8
Author: Aaron Wells <email address hidden>
Date: Wed Aug 26 18:32:52 2015 +1200

Fixing issues in embedded images in copied pages

Bug 1489274
- DB upgrade to fill in artefact_file_embedded records for
existing blog entries
- Improving the regex that rewrites links in copied journal
entries, notes, and text blocks

behatnotneeded: Requires upgrading the site; not testable via Behat

Change-Id: Ie5d5dc12065ed039df663910e5ee738d57377a91

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5182
Committed: https://git.mahara.org/mahara/mahara/commit/ffac44d15cc69516741c78af9bbac2d1a8b0bac4
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.04_STABLE

commit ffac44d15cc69516741c78af9bbac2d1a8b0bac4
Author: Aaron Wells <email address hidden>
Date: Wed Aug 26 18:32:52 2015 +1200

Fixing issues in embedded images in copied pages

Bug 1489274
- DB upgrade to fill in artefact_file_embedded records for
existing blog entries
- Improving the regex that rewrites links in copied journal
entries, notes, and text blocks

behatnotneeded: Requires upgrading the site; not testable via Behat

Change-Id: Ie5d5dc12065ed039df663910e5ee738d57377a91

Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
milestone: 16.04.1 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers