All edit and delete buttons should contain the name of what they manage

Bug #1487299 reported by Jono Mingard on 2015-08-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Cecilia Vela Gurovic

Bug Description

Reopening Bug #1276397 - in the new Bootstrap theme, all edit and delete buttons seem to have descriptive text attached to them ("Edit" and "Delete"), but it is sometimes ambiguous for screen reader users which list item they refer to. In particular:

- On the My groups page, Settings and Delete buttons should contain the name of the group (see Bug #1482482)
- In the Resume (Education and employment, Achievements) edit and delete buttons should contain some information about the row they are on
- Under Journals, all Edit and Delete buttons should include the name of the journal (or entry) they control
- Same for files in the file browser (eg. Content -> Files)

For an example of how to include this text, see the edit and delete buttons in the list on Portfolio -> Pages.

There are probably other examples - they should be added here and then could be spun off into separate bug reports for fixing.

Jono Mingard (mingard) on 2015-08-21
description: updated
Robert Lyon (robertl-9) on 2016-10-21
Changed in mahara:
milestone: 16.10.1 → 17.04.0
Robert Lyon (robertl-9) wrote :

These still need to be fixed up

Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Robert Lyon (robertl-9) on 2016-12-12
no longer affects: mahara/15.10
no longer affects: mahara/16.04
no longer affects: mahara/16.10

Fix for:
 - In the Resume (Education and employment, Achievements) edit and delete buttons should contain some information about the row they are on
- Under Journals, all Edit and Delete buttons should include the name of the journal (or entry) they control

Could not replicate for:

- On the My groups page, Settings and Delete buttons should contain the name of the group (fixed in Bug #1482482)
- Same for files in the file browser (eg. Content -> Files)

Reviewed: https://reviews.mahara.org/7330
Committed: https://git.mahara.org/mahara/mahara/commit/0457e857dcbc580ef739dc5aef2ad7d026297678
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0457e857dcbc580ef739dc5aef2ad7d026297678
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Dec 13 14:43:40 2016 +1300

Bug 1487299: Edit/delete buttons contain title in sr-only

added title in sr-only tags in edit/delete buttons in:
Resume (Education and employment, Achievements)
Journal lists and entry lists

behatnotneeded

Change-Id: If02f4fdeaf6ec0a5625cdbdf6a1969ae03159f5e

Robert Lyon (robertl-9) on 2017-01-11
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2017-04-27
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers