It would be nice to have a <legend> for the cell selector in the position block dialog

Bug #1482471 reported by Jono Mingard on 2015-08-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Jaque

Bug Description

The radio buttons to choose which cell a new block should be created in function well for screen reader and keyboard users, but it would be nice to have a <legend> element (saying "Cell", for example) associated with them to make their purpose more explicit.

Affects latest master

Jaque (jaque777) on 2018-02-18
Changed in mahara:
assignee: nobody → Jaque (jaque777)
Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/8533
Committed: https://git.mahara.org/mahara/mahara/commit/18bab0286e92a72f92b7e270d3d96646a9ebe320
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 18bab0286e92a72f92b7e270d3d96646a9ebe320
Author: Jaque <email address hidden>
Date: Wed Feb 21 13:29:14 2018 +1300

Bug #1482471: Add <legend> for the cell selector in the position block dialog

Add fieldset and legend to blocks

behatnotneeded

Change-Id: Iae4266b5261dbaef05586aca30c494580c1b991c

Robert Lyon (robertl-9) on 2018-02-26
Changed in mahara:
status: In Progress → Fix Committed
milestone: none → 18.04.0
Steven (stevens-q) wrote :
Steven (stevens-q) wrote :

Test Results

1. Logged in as admin user
2. Browse to Portfolio > Pages and collections
3. Create or edit a page
4. Add text block to the page
5. Confirm a popup modal window is displayed ✔
6. Confirm modal window has a title "Cell" just above the grey blocks ✔

NOTE: the number of grey blocks will depend on the layout for the page

Catalyst QA Approved ✔

Robert Lyon (robertl-9) on 2018-04-05
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers