Leap2a export: Filter out ASCII control characters that are not valid in XML

Bug #1482437 reported by Aaron Wells on 2015-08-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Aaron Wells
15.04
Medium
Unassigned
15.10
Medium
Aaron Wells

Bug Description

This is the flip-side to Bug 1482410. The patch for that bug will filter out illegal ASCII control characters from XML files, which stops SimpleXML from choking. But Mahara is still generating invalid XML, by making XML files that contain those characters.

We should add some code that also filters out invalid XML characters on the export side.

Aaron Wells (u-aaronw) wrote :

Testing instructions

Same test procedure described here: https://bugs.launchpad.net/mahara/+bug/1482410/comments/1

Reviewed: https://reviews.mahara.org/5062
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/395afc5f4078d0f20ff0b80afb0e2a66312512bd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 395afc5f4078d0f20ff0b80afb0e2a66312512bd
Author: Aaron Wells <email address hidden>
Date: Fri Aug 7 12:15:23 2015 +1200

Leap2a: filter invalid XML chars on export (Bug 1482437)

behatnotneeded: Can't test contents of exported Leap2a files
in behat yet.

Change-Id: I4a309d0656e379432e3e9a62d9d4e6892980ab46

Robert Lyon (robertl-9) on 2015-08-11
Changed in mahara:
status: In Progress → Fix Committed

Reviewed: https://reviews.mahara.org/5081
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/54865c53e6c3c5843a5622e29ab28b8ed7263fab
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 54865c53e6c3c5843a5622e29ab28b8ed7263fab
Author: Aaron Wells <email address hidden>
Date: Fri Aug 7 12:15:23 2015 +1200

Leap2a: filter invalid XML chars on export (Bug 1482437)

behatnotneeded: Can't test contents of exported Leap2a files
in behat yet.

Change-Id: I4a309d0656e379432e3e9a62d9d4e6892980ab46
(cherry picked from commit 395afc5f4078d0f20ff0b80afb0e2a66312512bd)

Robert Lyon (robertl-9) on 2016-11-06
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers