webservice mahara_user_get_users doesn't work (or do what it implies)

[Howard Miller]

There's no reason to suspect from the description that this function does anything other than return all users on the site. However, running it returns an empty array

On further investigation, the query returning the users looks for them being in an institution called $WEBSERVICE_INSTITUTION (a global variable!!). I think what's going on is that the authentication code is trying to set the global to match the institution of the user using webservices so that it only returns that user's list of users. However, if that person has admin rights then it probably isn't going to work.

I'm not sure that this is really a bug or it's working as intended, but it probably needs to be made clearer what it actually does. This institution 'side affect' seems to effect a number of the services.

[Howard Miller (howardsmiller)]

Ahh... my mistake. This *is* what it does.

Just for the record, the site was 'closed' but webservice calls just fails silently - even when the user has admin rights.