Remote avatar (Gravatar) does not adhere to site proxy settings

Bug #1457032 reported by Hittesh Ahuja on 2015-05-20
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Aaron Wells
15.04
Medium
Aaron Wells
15.10
Medium
Aaron Wells

Bug Description

When using a mahara site with proxy enabled , remote avatar function does after trying to get the avatar from the internet(after 120 s) .This makes browsing the site really slow behind a firewall . This happens due to the fact that get_headers function under lib/user.php page does not support proxy calls .

A way to get around this is to use stream_context_set_default before call to get_headers and use the proxy there.

Patch for the fix has been submitted.

Hittesh

Changed in mahara:
status: New → Confirmed
Robert Lyon (robertl-9) on 2015-07-15
Changed in mahara:
status: Confirmed → In Progress
importance: Undecided → Medium
milestone: none → 15.10.0
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/4972

This one's a regression introduced in Mahara 15.04.0, by this patch: https://reviews.mahara.org/#/c/3760/

tags: added: gravatar regression
Aaron Wells (u-aaronw) wrote :

I've submitted patch https://reviews.mahara.org/4972 to replace patch https://reviews.mahara.org/4958.

The difference is that patch 4972 uses the mahara_http_request method, which observes all of Mahara's standards & settings around HTTP requests.

Reviewed: https://reviews.mahara.org/4972
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/854b64aef13939a389f7b8f4d5dfa8361f052788
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 854b64aef13939a389f7b8f4d5dfa8361f052788
Author: Aaron Wells <email address hidden>
Date: Thu Jul 16 17:18:35 2015 +1200

Use standard Mahara curl methods for gravatar header request (Bug 1457032)

By using the standard methods we make sure that we respect proxy settings,
future security methods, etc.

Change-Id: I2870aac0e3a68080e8af35e4f113c151aa812352

Reviewed: https://reviews.mahara.org/4975
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/fa60dae04c8a172f731049bbc4ee6fc3fab1ae5a
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit fa60dae04c8a172f731049bbc4ee6fc3fab1ae5a
Author: Aaron Wells <email address hidden>
Date: Thu Jul 16 17:18:35 2015 +1200

Use standard Mahara curl methods for gravatar header request (Bug 1457032)

By using the standard methods we make sure that we respect proxy settings,
future security methods, etc.

Change-Id: I2870aac0e3a68080e8af35e4f113c151aa812352
(cherry picked from commit 854b64aef13939a389f7b8f4d5dfa8361f052788)

Aaron Wells (u-aaronw) wrote :

Hi Hittesh,

I just wanted to add, thanks for reporting this issue! :)

Cheers,
Aaron

summary: - remote avar does not adhere to site proxy settings
+ Remote avatar (Gravatar) does not adhere to site proxy settings
Hittesh Ahuja (hitteshahuja) wrote :

Hi Aaron,
No worries. Glad I could be of any help :)

Regards
Hittesh

Robert Lyon (robertl-9) on 2016-11-06
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers