15.04 image picker requires PHP 5.3.6+

[Aaron Wells]

As reported on the Mahara.org forums: https://mahara.org/interaction/forum/editpost.php?parent=29019

The awesome new TinyMCE Mahara image picker in Mahara 15.04, uses the $node argument of the DomDocument::saveHTML() method. This argument was only added in PHP 5.3.6.

The problem is that, as of the last developer meeting, we purport to support Debian 6 (Squeeze) and later. But Squeeze only ships with PHP 5.3.3.

So if we want to continue to claim to support Squeeze, we should probably make this work without the $node argument. Or, we should specify that we require at least PHP 5.3.6, and that if you're running it on Squeeze, you'll just have to manually upgrade your PHP version.

Actually, in the README that shipped with 15.04 we put that we support Debian 5 (Lenny) which ships with PHP 5.2... so presumably it's already implied that you're manually upgrading your PHP version.

[Aaron Wells (u-aaronw)]

(Note that the forum post was from someone running PHP on RHEL <7, which is not one of our officially supported systems. Although of course it's always a plus when Mahara will run on systems other than Debian & Ubuntu.)

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/4914

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4914
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/cbe94a4c77ef9f1ad83449b379c1264a2bdd77bd
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit cbe94a4c77ef9f1ad83449b379c1264a2bdd77bd
Author: Robert Lyon <email address hidden>
Date: Thu Jul 2 13:42:18 2015 +1200

Bug 1451331: Saving of text block with embedded media for old PHP

The DOMDocument::saveHTML() function only gained the $node parameter
in version 5.3.6

So we need a workaround for PHP 5.3.3

Change-Id: I1033c0411f25cd41a4ec83cd2258fc518927e3ab
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4915

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4915
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/f49775838d62087aacde917d575000e780d7246f
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit f49775838d62087aacde917d575000e780d7246f
Author: Robert Lyon <email address hidden>
Date: Thu Jul 2 13:42:18 2015 +1200

Bug 1451331: Saving of text block with embedded media for old PHP

The DOMDocument::saveHTML() function only gained the $node parameter
in version 5.3.6

So we need a workaround for PHP 5.3.3

Change-Id: I1033c0411f25cd41a4ec83cd2258fc518927e3ab
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit cbe94a4c77ef9f1ad83449b379c1264a2bdd77bd)