Mahara

allow loading of lang string into js strings object after page load

Bug #1450995 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 15.10.0
15.10
Fix Released
Undecided
Unassigned

Bug Description

Now that we are using more ajax for loading things in Mahara sometimes we end up loading something that needs lang strings but they are not present when the page loads and so are not in the 'strings' object.

It would be good if we could try and load a lang string via ajax as well if it wasn't found in the 'strings' object.

So I will add a js function for that.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4725

Jinelle Foley-Barnes (jinelleb)
tags: added: no-behat-needed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4725
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/05a80e6ab6a1dce454f58d4980e34fc1527d9041
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 05a80e6ab6a1dce454f58d4980e34fc1527d9041
Author: Robert Lyon <email address hidden>
Date: Sat May 2 21:30:40 2015 +1200

Allowing lang strings in js to be loaded via ajax (Bug #1450995)

So that they can be added to the strings object after page load

Change-Id: I4ba00accfad1e0981997488de600d9d53c561602
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: In Progress → Fix Committed
tags: added: nominatedfeature
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.