TinyMCE disappears from feedback form after validation fails

[Aaron Wells]

If you try post feedback, but the form validation fails, we re-display the feedback form. However, in this case, the TinyMCE no longer displays properly.

To replicate:

1. Create a page (which allows comments)
2. Click on "Place feedback" on the bottom of the page
3. Click "Submit" without filling in a comment.
4. This will cause the feedback to fail validation, and the page will reload with a message telling you what you did wrong.

Expected result: You should see the same feedback form, with the "Message" field displaying an error.
Actual result: You see the feedback form, but now the "Message" field is no longer TinyMCE.

[Aaron Wells (u-aaronw)]

This is true for:

1. Feedback on portfolio pages
2. Feedback on artefact detail pages
3. Feedback in the feedback block on a portfolio page.

This bug is present in 1.10 and later, but not in 1.9.

[Aaron Wells (u-aaronw)]

Using git bisect reveals that this started with the upgrade to TinyMCE 4. https://reviews.mahara.org/#/c/3030/

[Aaron Wells (u-aaronw)]

I came across this while trying implement Bug 1432464. When I add a recaptcha to the comment form, it doesn't display properly after validation fails either.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/4785

[Mahara Bot (dev-mahara)]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4793

[Mahara Bot (dev-mahara)]

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/4794

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4794
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/27f6cdb12a83fee396ad695da6376702d0e36d66
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit 27f6cdb12a83fee396ad695da6376702d0e36d66
Author: Son Nguyen <email address hidden>
Date: Fri May 22 13:33:18 2015 +1200

Make sure TinyMCE shows up on Feedback forms after failure to submit

Bug 1450705: The normal Wysiwyg Pieform element's "onload()" can't
handle the TinyMCE in the feedback area, because of the additional
Feedback logic for hiding & showing the Feedback form.

Change-Id: Ic2c7ad8c2ce8720ba1fcaf19c3ec71b6529b4ff0

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4793
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/94e6d0f49c73b2c003349fd7207bb4aeedc2b367
Submitter: Aaron Wells (<email address hidden>)
Branch: 15.04_STABLE

commit 94e6d0f49c73b2c003349fd7207bb4aeedc2b367
Author: Son Nguyen <email address hidden>
Date: Fri May 22 13:33:18 2015 +1200

Make sure TinyMCE shows up on Feedback forms after failure to submit

Bug 1450705: The normal Wysiwyg Pieform element's "onload()" can't
handle the TinyMCE in the feedback area, because of the additional
Feedback logic for hiding & showing the Feedback form.

Change-Id: Ic2c7ad8c2ce8720ba1fcaf19c3ec71b6529b4ff0

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4785
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/267f6bc2b7e61f0a9cb6c0598a884af714460495
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 267f6bc2b7e61f0a9cb6c0598a884af714460495
Author: Son Nguyen <email address hidden>
Date: Fri May 22 13:33:18 2015 +1200

Make sure TinyMCE shows up on Feedback forms after failure to submit

Bug 1450705: The normal Wysiwyg Pieform element's "onload()" can't
handle the TinyMCE in the feedback area, because of the additional
Feedback logic for hiding & showing the Feedback form.

Change-Id: Ic2c7ad8c2ce8720ba1fcaf19c3ec71b6529b4ff0