Social media buttons are not visible to others

Bug #1448948 reported by Kristina Hoeppner on 2015-04-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.10
High
Unassigned
15.04
High
Unassigned
15.10
High
Robert Lyon

Bug Description

Confirmed for Mahara 1.10 and 15.04 (and therefore also a problem on master)

When I add social media profile buttons via the "Social media" block to a page, others cannot see those buttons. Only I can see them.

tags: added: needs-behat
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/4704

tags: added: has-behat
removed: needs-behat

Reviewed: https://reviews.mahara.org/4697
Committed: http://gitorious.org/mahara/mahara/commit/a85542f23f741d497f7baecf2b60e8ad65bce5db
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit a85542f23f741d497f7baecf2b60e8ad65bce5db
Author: Robert Lyon <email address hidden>
Date: Tue Apr 28 12:01:03 2015 +1200

Render social profile block with block owner's data (Bug #1448948)

It was incorrectly rendering it with current user's data.

Also fixed a problem with facebook social profile - if one didn't add
full url it will now append facebook domain to string

Change-Id: Ia8b82b054d26afa7b3d0d074b5d9d97ab3f8c762
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/4732

Reviewed: https://reviews.mahara.org/4704
Committed: http://gitorious.org/mahara/mahara/commit/a06573695ad19f9d4e0b0a11544a25f7398e5df0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a06573695ad19f9d4e0b0a11544a25f7398e5df0
Author: Jinelle Foley-Barnes <email address hidden>
Date: Tue Apr 28 14:33:02 2015 +1200

Behat Test: Social media buttons (Bug 1448948)

This may need some work still, but I'm pushing it so I can rebase and get all the fixes
from master.

Change-Id: I4b4d5ff9fc879ff38ea69d30d41b166b3098c6ca

Reviewed: https://reviews.mahara.org/4732
Committed: http://gitorious.org/mahara/mahara/commit/f124221a56c9f75046306a779af346bbc711015e
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit f124221a56c9f75046306a779af346bbc711015e
Author: Robert Lyon <email address hidden>
Date: Tue Apr 28 12:01:03 2015 +1200

Render social profile block with block owner's data (Bug #1448948)

It was incorrectly rendering it with current user's data.

Also fixed a problem with facebook social profile - if one didn't add
full url it will now append facebook domain to string

Change-Id: Ia8b82b054d26afa7b3d0d074b5d9d97ab3f8c762
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4731
Committed: http://gitorious.org/mahara/mahara/commit/b2a732d459f1900c1bc738800fa319cdb8f1ed0e
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit b2a732d459f1900c1bc738800fa319cdb8f1ed0e
Author: Robert Lyon <email address hidden>
Date: Tue Apr 28 12:01:03 2015 +1200

Render social profile block with block owner's data (Bug #1448948)

It was incorrectly rendering it with current user's data.

Also fixed a problem with facebook social profile - if one didn't add
full url it will now append facebook domain to string

Change-Id: Ia8b82b054d26afa7b3d0d074b5d9d97ab3f8c762
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/4746
Committed: http://gitorious.org/mahara/mahara/commit/96a1f4effed05ce0364f434c5e0af889f7cb6738
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 96a1f4effed05ce0364f434c5e0af889f7cb6738
Author: Robert Lyon <email address hidden>
Date: Wed May 6 14:46:13 2015 +1200

Bug 1448948: fixing problems with the behat test

Change-Id: If2b882d383f04905598c0d1fa28c2cfa66d75cd5
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/4754
Committed: http://gitorious.org/mahara/mahara/commit/a5ccf1bf2774d8b1846a54f890065425e9f0320f
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit a5ccf1bf2774d8b1846a54f890065425e9f0320f
Author: Robert Lyon <email address hidden>
Date: Wed May 6 14:46:13 2015 +1200

Bug 1448948: fixing problems with the behat test

Change-Id: If2b882d383f04905598c0d1fa28c2cfa66d75cd5
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4741
Committed: http://gitorious.org/mahara/mahara/commit/f2b51b09f57e58e3ffe731a43634ce91cb493e0a
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit f2b51b09f57e58e3ffe731a43634ce91cb493e0a
Author: Jinelle Foley-Barnes <email address hidden>
Date: Tue Apr 28 14:33:02 2015 +1200

Behat Test: Social media buttons (Bug 1448948)

This may need some work still, but I'm pushing it so I can rebase and get all the fixes
from master.

Change-Id: I4b4d5ff9fc879ff38ea69d30d41b166b3098c6ca

Robert Lyon (robertl-9) on 2016-11-06
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers