Leaving feedback on own page generates notification to self

Bug #1444182 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

We don't need to receive a notification when we comment on our own page as we already know we have done that.

To test:

1) Install fresh mahara
2) Add a user: UserA
3) Login as UserA and create a page
4) Leave feedback on page (doesn't matter if first feeback or replying to other's feedback)
5) Check inbox - there is a message both 'to' and 'from' UserA

Will mark this as a low bug as it's more of an annoyance than the system being broken.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

I'll mark it as medium because it could be a fairly major annoyance.

Changed in mahara:
importance: Low → Medium
assignee: nobody → Aaron Wells (u-aaronw)
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 15.10.0 → 16.04.0
Changed in mahara:
milestone: 16.04.0 → 16.04.1
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.1 → 16.04.2
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.2 → 16.04.3
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.3 → 16.04.4
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.4 → 16.04.5
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.5 → 16.04.6
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.6 → 16.04.7
assignee: Aaron Wells (u-aaronw) → nobody
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.04.7 → 17.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8036

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8036
Committed: https://git.mahara.org/mahara/mahara/commit/e9075aa3a07d9d785e1e3f56cebd402e045186b9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e9075aa3a07d9d785e1e3f56cebd402e045186b9
Author: Robert Lyon <email address hidden>
Date: Wed Sep 20 09:54:42 2017 +1200

Bug 1444182: Stop sending self notifications

Stop sending comment notifications to page owner when
page owner is the commentor

behatnotneeded

Change-Id: Ibfe80b7bb57855592e7d04cc653c649b7d08a148
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.