Feedback notifications list "System" for the "From" field

Bug #1443282 reported by Aaron Wells on 2015-04-13
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
High
Aaron Wells

Bug Description

To replicate:

1. Log in as user A and create a page.
2. Allow feedback on the page. Make the page public.
3. Log in as user B and put the page on your watchlist.
4. Log in as user A and place feedback on the page.

Expected result: User B should receive a notification in their inbox about the comment, showing user A as the author.
Actual result: User B receives a notification in their inbox, but the author is "System".

Reviewed: https://reviews.mahara.org/4596
Committed: http://gitorious.org/mahara/mahara/commit/5de39ecf0e70a7ff12e0d1a7d7498b6ae9c8937c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5de39ecf0e70a7ff12e0d1a7d7498b6ae9c8937c
Author: Aaron Wells <email address hidden>
Date: Mon Apr 13 19:10:41 2015 +1200

Bug 1443282: Show the proper author in feedback notifications

Unfortunately this doesn't work for anonymous feedback, because
the notification_internal_activity table only has an integer
column for the userid in the "from" column. To handle anonymous
feedback we would need a string for the "from" column.

Change-Id: Ia429a548b371d30166775e51f95cd5998062445f

Reviewed: https://reviews.mahara.org/4614
Committed: http://gitorious.org/mahara/mahara/commit/74d6a245f765a86d0f978dbbd588cd8b93ef7894
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 74d6a245f765a86d0f978dbbd588cd8b93ef7894
Author: Aaron Wells <email address hidden>
Date: Mon Apr 13 19:10:41 2015 +1200

Bug 1443282: Show the proper author in feedback notifications

Unfortunately this doesn't work for anonymous feedback, because
the notification_internal_activity table only has an integer
column for the userid in the "from" column. To handle anonymous
feedback we would need a string for the "from" column.

Change-Id: Ia429a548b371d30166775e51f95cd5998062445f

Robert Lyon (robertl-9) on 2015-04-14
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers