"cancel" link shows up when you clink on a file thumbnail in Contents -> Files

Bug #1441945 reported by Aaron Wells on 2015-04-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
15.04
High
Unassigned
15.10
High
Unassigned

Bug Description

While playing around with 15.10dev, I noticed that if I go to Content -> Files, and click on the thumbnail of one of my images, it makes a link show up underneath the thumbnail that says "-> cancel". Clicking this just seems to take me to "#". I'm guessing this probably the remnants of some Javascript that we've removed in the past.

Aaron Wells (u-aaronw) wrote :
Robert Lyon (robertl-9) wrote :

This was added for accessibility

 - if you have folders then you will get a list of folders (as well as the cancel) so that you can click a folder name link to move the file to that folder.

So the bug is "when there is no folder to move file to the 'cancel' link shouldn't show".

Robert Lyon (robertl-9) wrote :

See the htdocs/artefact/file/js/filebrowser.js around line 498 for where the cancel link is added

Robert Lyon (robertl-9) on 2015-04-09
tags: removed: regression

Reviewed: https://reviews.mahara.org/4593
Committed: http://gitorious.org/mahara/mahara/commit/c859f4972ca3e9a5ad425c4afeba3685d7ba0113
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit c859f4972ca3e9a5ad425c4afeba3685d7ba0113
Author: Robert Lyon <email address hidden>
Date: Mon Apr 13 17:14:30 2015 +1200

Bug 1441945: showing the 'cancel' option when we don't need to

In the Content -> Files section if we have no folders then we don't
need to show the accessibility links when we click the file icon.

Same for when we have only one folder and we click the folder icon

Change-Id: Ibd7257bdb766d2d9da32c86d03a9e33120243d0b
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/4609
Committed: http://gitorious.org/mahara/mahara/commit/3028b31636ad78a48d52ca0ecf1672cda9d66d64
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 3028b31636ad78a48d52ca0ecf1672cda9d66d64
Author: Robert Lyon <email address hidden>
Date: Mon Apr 13 17:14:30 2015 +1200

Bug 1441945: showing the 'cancel' option when we don't need to

In the Content -> Files section if we have no folders then we don't
need to show the accessibility links when we click the file icon.

Same for when we have only one folder and we click the folder icon

Change-Id: Ibd7257bdb766d2d9da32c86d03a9e33120243d0b
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
tags: added: behat-needed
tags: added: behat
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments