WYSIWYG editor image picker not showing tabs correctly

Bug #1440930 reported by Robert Lyon on 2015-04-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned

Bug Description

If I pick to add an image in the TinyMCE when in edit details on page or in forum post the user/group/site tabs are not showing correctly

But if I add a text block to a page and try and upload image via tinymce icon the tabs are present and correct.

Robert Lyon (robertl-9) wrote :
Robert Lyon (robertl-9) wrote :

Also the overlay background is not present outside the edit block page. This is due to the tinymce imagebrowser dialogue not being a child of the block configure dialogue (which adds the overlay).

I've adjusted the tinymce imagebrowser dialogue to add in the overlay if it's not already present and then remove it again if it was added by this dialogue.

Robert Lyon (robertl-9) wrote :

Evonne fixed up the css for this and I've added to the same patch.

Reviewed: https://reviews.mahara.org/4582
Committed: http://gitorious.org/mahara/mahara/commit/69dffdf292cfad595431cc7254ac80da7e7e44a0
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 69dffdf292cfad595431cc7254ac80da7e7e44a0
Author: Robert Lyon <email address hidden>
Date: Tue Apr 7 12:42:12 2015 +1200

Allow imagebrowser tabs to work outside block edit page (Bug #1440930)

Includes adding overlay div

Change-Id: Iff8bb1472ddda84ab622420193a36018fcbdac9b
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/4587
Committed: http://gitorious.org/mahara/mahara/commit/a88f735298896624623abf113a55df5042e021f3
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit a88f735298896624623abf113a55df5042e021f3
Author: Robert Lyon <email address hidden>
Date: Tue Apr 7 12:42:12 2015 +1200

Allow imagebrowser tabs to work outside block edit page (Bug #1440930)

Includes adding overlay div

Change-Id: Iff8bb1472ddda84ab622420193a36018fcbdac9b
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2015-04-07
Changed in mahara:
status: Confirmed → Fix Committed
Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments