Username is shown in "Inbox", "Sent messages", "Online users" and on page

[Kristina Hoeppner]

Regression in 15.04RC1

When I'm logged in as regular user (no staff or admin), I can see my username in in the "Online users" sidebar, in the "Inbox" and "Sent" messages area as well as on a portfolio page. That was not the case in 1.10 and shouldn't be the case. I don't see the usernames of other people and the site has "Don't display usernames" activated.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/4479

[Robert Lyon (robertl-9)]

Turns out the code change here: https://reviews.mahara.org/#/c/3581/6/htdocs/lib/user.php

was a bit over zealous with the

  $userto === $user

- it was allowing "if current user matches user to display" then show username as well

But that is not what we want for normal users so have removed it

[Jinelle Foley-Barnes (jinelleb)]

Hi,

Am I supposed to see the user and admins name on the sidebar to the right?
From the bug report I don't think I am. This screen shot is from a user being logged in.

Thanks,
Jinelle

[Robert Lyon (robertl-9)]

Ok with this if you are an admin you should see the Name + (username) for the users

If you are a normal user and don't have display name (under Content -> Profile) set you should see your firstname + lastname

If you are a normal user and do have display name set you should see your displayname

you should not see your (username) - the one in brackets

[Robert Lyon (robertl-9)]

Hi Jinelle

Ok, looking at your screenshot:

When both admin and student have logged in recently -

When you are logged in as admin user:

You should see both users as "Firstname Lastname (username)"

When you are logged in as student user:

You should see both users as "Firstname Lastname"

Does that make sense?

Cheers

Robert

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4479
Committed: http://gitorious.org/mahara/mahara/commit/3bb91448893ac060a86d4100fa032f47a8952dc2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3bb91448893ac060a86d4100fa032f47a8952dc2
Author: Robert Lyon <email address hidden>
Date: Fri Mar 27 13:10:29 2015 +1300

Remove the display of the username for normal users (Bug #1434935)

This is a fix for a regression which introduced the display of the
username in various areas of Mahara where they were not displayed
before.

Change-Id: I0e63cc99ef55ae51d1276e5f776a16d7e1934f23
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4517

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4517
Committed: http://gitorious.org/mahara/mahara/commit/9b0c117d8cd7a929b992b7ccbdd4010ca56c39f3
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 9b0c117d8cd7a929b992b7ccbdd4010ca56c39f3
Author: Robert Lyon <email address hidden>
Date: Fri Mar 27 13:10:29 2015 +1300

Remove the display of the username for normal users (Bug #1434935)

This is a fix for a regression which introduced the display of the
username in various areas of Mahara where they were not displayed
before.

Change-Id: I0e63cc99ef55ae51d1276e5f776a16d7e1934f23
Signed-off-by: Robert Lyon <email address hidden>