Support for JS lang strings in artefact blocktypes

Bug #1431679 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Aaron Wells

Bug Description

Mahara has a system set up to allow language strings to be accessed via Javascript: https://wiki.mahara.org/index.php/Developer_Area/Language_strings#How_to_use_lang_strings_from_Javascript

There's a spinoff of this for JS lang strings provided by plugins. If a JS file is loaded from a plugin's "js" directory, and the plugin class has a public static "jsstrings" method, then that method is called to load up strings for the page.

BUT, this doesn't work for blocktypes that live under artefacts. And I need it to work for the artefact/annotation/blocktype/annotation block. (See Bug 1431673)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4403

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4403
Committed: http://gitorious.org/mahara/mahara/commit/b552de97e0b141595a052f378d91ba601c29c2ad
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b552de97e0b141595a052f378d91ba601c29c2ad
Author: Aaron Wells <email address hidden>
Date: Fri Mar 13 18:01:16 2015 +1300

Provide support for JS lang strings in artefact blocktypes

Bug 1431679. This should let blocktypes that live underneath
artefacts, provide lang strings for JS the same as other plugins can.

Change-Id: I08ca4d15c44418affeb1877b0ac78940ca215c49

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.