Hard-coded language string in artefact/annotation/js/annotation.js

Bug #1431673 reported by Aaron Wells on 2015-03-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Ghada El-Zoghbi

Bug Description

I just noticed a hard-coded English language string in the artefact plugin's "annotation.js" file.

In the function "ConnectAnnotationFeedbackLinks()", on line 248:

                                var closer = $j('<a id="closer_' + blockid + '" href="#" class="close-link">Close</a>').click(function(e) {

The word "Close" in the middle of that <a> tag needs to be replaced with a language string. See https://wiki.mahara.org/index.php/Developer_Area/Language_strings#How_to_use_lang_strings_from_Javascript for how to use a language string from Javascript.

Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/4404
Committed: http://gitorious.org/mahara/mahara/commit/cba61086e073537fff883ffda9637a490b826ede
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit cba61086e073537fff883ffda9637a490b826ede
Author: Aaron Wells <email address hidden>
Date: Fri Mar 13 18:29:37 2015 +1300

Hard-coded lang string in blocktype/annotation Javascript

Bug 1431673. In order to replace this with a proper lang string,
I had to change the annotation blocktype so that it's using
the proper APIs for its JS file.

Change-Id: I5155be2505f4986e424bf2909769377de7cd8c42

Robert Lyon (robertl-9) on 2015-03-18
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers