Embedded images in 'Text' block did not show after copying or importing

Bug #1425728 reported by Son Nguyen on 2015-02-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Son Nguyen

Bug Description

Version: master (15.04)

After copying a page with embedded images in 'Text' blocks, these images are copied and stored in 'Home/viewfiles' area but not show in the 'Text' block.

Son Nguyen (ngson2000) on 2015-02-25
Changed in mahara:
importance: Undecided → High
status: Confirmed → In Progress
Son Nguyen (ngson2000) wrote :

This bug also happens when importing the page via LEAP2a

summary: - Embedded images in 'Text' block did not show after copying
+ Embedded images in 'Text' block did not show after copying or importing

Reviewed: https://reviews.mahara.org/4328
Committed: http://gitorious.org/mahara/mahara/commit/2b259a85cc9fb752a03bd6f6345ae4c32043e267
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2b259a85cc9fb752a03bd6f6345ae4c32043e267
Author: Son Nguyen <email address hidden>
Date: Thu Feb 26 14:45:38 2015 +1300

Fix embedded images in 'Text' block when copy and import. Bug 1425728

- Add new method PluginBlocktype::rewrite_blockinstance_extra_config()
which enables blocktype to rewrite extra configuration when copying
block

- Implement rewrite_blockinstance_extra_config() for
PluginBlocktypeText to rewrite embedded image urls in the text block

- Rename the method rewrite_artefact_ids() to
rewrite_blockinstance_config() and add new code to allow blocktype
plugins rewrite extra config when import

- Add new method
PluginBlocktype::import_rewrite_blockinstance_extra_config_leap()

- Implement
PluginBlocktypeText::import_rewrite_blockinstance_extra_config_leap() to
rewrite embedded image urls in configdata['text']

Change-Id: Id5163817c676fb118edea02d152b7797111cb99f

Robert Lyon (robertl-9) on 2015-03-04
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers