Behat bug: Behat gets confused by the 2 different Groups in navigation

[Jinelle Foley-Barnes]

Hi,

I have a attached a broken Behat test. When it clicks on the first "Groups" heading in the navigation it works fine.
eg "Find friends" in "Groups"

Then it fails when it tries selecting "Archived submissions" in "Groups" .

It doesn’t like the fact that there are 2 of them. What way do we have to work around this?

Thanks,
Jinelle

[Son Nguyen (ngson2000)]

The problem is the xpath of menu "Groups" is not consistent to other menu.

For example, the xpath of
- "Users" is //div[@id='main-nav']/ul[@id="nav"]/li/span/a[.="Users"]
- "Institutions" is //div[@id='main-nav']/ul[@id="nav"]/li/span/a[.="Institutions"]

while "Groups" is //div[@id='main-nav']/ul[@id="nav"]/li//span/a/span[.="Groups"]

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/4326

[Robert Lyon (robertl-9)]

The 'Groups' menu item in the admin section has an accessible hidden value "(Administer groups)" as well
so

 Find "Archived submissions" in "Groups"

will fail but

 Find "Archived submissions" in "Groups (Administer groups)" will pass without needing patch 4326

So do we want to make it clearer in our behat tests that we are talking about "Groups" in admin vs "Groups" in normal area by using "Groups (Administer groups)" or not?

[Son Nguyen (ngson2000)]

Yes, it is clearer to use accessible hidden values to identify the menu item.
However, it would require testers to find out the hidden value.

I will also fix the navigation steps to deal only with the visible text which is seen by testers

[Robert Lyon (robertl-9)]

Will drop down the importance as there is a current work around to use the hidden accessibility test

[Robert Lyon (robertl-9)]

Will leave the workaround as the preferred fix for this and so will close the bug