Annoying gray line shows up under images with no comments & no comments allowed

Bug #1419547 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Aaron Wells

Bug Description

I noticed this when I was choosing a profile icon for an image in a page, while fixing Bug 1419539.

To replicate:

1. Upload an image file

2. Turn off comments for that image file (i.e. go to Content -> Files, click the "edit" pencil icon next to the image, then untick "allow comments" and save.

3. Place the image in an image block

Expected result: You should see the image displayed by the block

Actual result: You see the image, plus a gray bar around the bottom of it. This is the set of <divs> where comment information would show up if there were any comments. You can see this under the upper-left image block in the attached image.

Revision history for this message
Aaron Wells (u-aaronw) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4257

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4257
Committed: http://gitorious.org/mahara/mahara/commit/d05c68b8b207915304083c59f14cf2461cd0d539
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d05c68b8b207915304083c59f14cf2461cd0d539
Author: Aaron Wells <email address hidden>
Date: Mon Feb 9 11:16:14 2015 +1300

Don't display comments area for images with no comments & comments disallowed

Bug 1419547

Change-Id: I2419b6443ad66992ca40d47263690c62ad5d9576

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.