Incorrect debug message

[Jim Thorpe]

The debug info in the following section appears to be incorrect

/mahara/auth/lib.php:
 2604 public static function save_instance_config_options($values, Pieform $form) {
 2605 throw new SystemException('This plugin claims to have instance config but does not define a '
 2606: . 'submit_instance_config_options() method. Most likely it is still using the get_config_options() '
 2607 . 'method for this purpose. Please ask the developer to upgrade the plugin.');
 2608 }

I believe that
submit_instance_config_options()
should be changed to
save_instance_config_options()

and
get_config_options()
should be changed to
save_config_options()

This was encountered when attempting to install the (oldish) Shibboleth plugin on Mahara 1.10.

Please ask if you require more information.

[Aaron Wells (u-aaronw)]

Thanks for the bug report! You're right, the function names in that warning message are incorrect. It appears I just wrote them wrong when writing patch https://reviews.mahara.org/#/c/3453/1 and nobody noticed.

I'll submit a patch to correct this.

Cheers,
Aaron

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/4249

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4249
Committed: http://gitorious.org/mahara/mahara/commit/3e0d955f79b850178a5584ab21f1d80ad3a79271
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 3e0d955f79b850178a5584ab21f1d80ad3a79271
Author: Aaron Wells <email address hidden>
Date: Tue Feb 3 18:02:02 2015 +1300

Incorrect function names in auth plugin debugging message

Bug 1416935

Change-Id: I7f42d4907b523dbb74c8f896f1ca3b01449a0e1a

[Mahara Bot (dev-mahara)]

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/4250

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4250
Committed: http://gitorious.org/mahara/mahara/commit/2daf59be99db8445dbe623e469e6cb67dd31154d
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit 2daf59be99db8445dbe623e469e6cb67dd31154d
Author: Aaron Wells <email address hidden>
Date: Tue Feb 3 18:02:02 2015 +1300

Incorrect function names in auth plugin debugging message

Bug 1416935

Change-Id: I7f42d4907b523dbb74c8f896f1ca3b01449a0e1a