"Text" block no longer available on page builder, after upgrade 1.9 -> 15.04dev
Bug #1401708 reported by
Aaron Wells
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Aaron Wells |
Bug Description
If you do an upgrade directly from Mahara 1.9 to 15.04dev, the "Text" block isn't available in the block pallette on the page builder. (It should show up next to the "Text" block).
There is no problem if you do a clean install, or if you upgrade from 1.10.
Using git bisect I traced it to this patch: https:/
Probably the problem is that our code that uses the "Shortcut" category to identify the blocks that should be placed in the shortcut, is not compatible with the code that we used to convert the 1.9 "text box" block into the 1.10 "text" block.
Changed in mahara: | |
status: | Confirmed → In Progress |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Right, so the problem is that new plugins get installed before core upgrades run. So what's happening is this:
1. The new "text" blocktype goes to install. It uses the method install_ blocktype_ categories_ for_plugin( ) to fill in the plugin's categories. This method looks for the available categories in the "blocktype_ category" table. It doesn't find "shortcut" there, so it skips that one, leaving the "text" blocktype in no categories.
2. The core upgrade runs and sets up the "shortcut" category type.
I'll have to do a little research to figure out the best way to resolve this. I'd like to think that it makes more sense to install new plugins *after* running core upgrades and maybe upgrades for existing plugins as well. But certainly before we make a change that big to the install process, we need to look at the code history and determine whether there's a reason why the new plugin installs come first.