Cannot cancel comment form after validation fails

Bug #1400511 reported by Yuliya Bozhko on 2014-12-08
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Low
Yuliya Bozhko
1.10
Low
Unassigned
1.8
Low
Unassigned
1.9
Low
Unassigned
15.04
Low
Yuliya Bozhko

Bug Description

To reproduce:

1. Go to any page
2. Submit an empty comment
3. See the form validation fail.
4. Now try to cancel the form.

What should happen: form should be cancelled

What happens: JS error, "Cannot read property 'tablerows' of undefined"...

Aaron Wells (u-aaronw) wrote :

A quick look indicates this problem has existed at least since Mahara 1.5!

Since it's a low-priority bug, it's probably not worth backporting to any earlier than 1.10, though.

Aaron Wells (u-aaronw) wrote :

Yuliya's patch for this bug: https://reviews.mahara.org/#/c/4065/

Reviewed: https://reviews.mahara.org/4065
Committed: http://gitorious.org/mahara/mahara/commit/55f3b731b3e0898581469d33f4c206bdf91f835e
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 55f3b731b3e0898581469d33f4c206bdf91f835e
Author: Yuliya Bozhko <email address hidden>
Date: Tue Dec 9 11:07:02 2014 +1300

Fix page error on form cancel after validation fails (Bug #1400511)

Change-Id: I63c4c566504492abb947202f8cf3ba5838770c9f
Signed-off-by: Yuliya Bozhko <email address hidden>

Reviewed: https://reviews.mahara.org/4074
Committed: http://gitorious.org/mahara/mahara/commit/3a44d1ed730aac28b7d0439f575ca94f688fa992
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit 3a44d1ed730aac28b7d0439f575ca94f688fa992
Author: Yuliya Bozhko <email address hidden>
Date: Tue Dec 9 11:07:02 2014 +1300

Fix page error on form cancel after validation fails (Bug #1400511)

Change-Id: I63c4c566504492abb947202f8cf3ba5838770c9f
Signed-off-by: Yuliya Bozhko <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "1.8_STABLE" branch: https://reviews.mahara.org/4076

Aaron Wells (u-aaronw) wrote :

On second thought, it's such a small, sensible code change, and it applies cleanly to 1.8 & 1.9 and works in them, so I've gone ahead and backported it to them as well.

Reviewed: https://reviews.mahara.org/4075
Committed: http://gitorious.org/mahara/mahara/commit/f89e097604602a034ba0cad39a4c3c72b03b2436
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.9_STABLE

commit f89e097604602a034ba0cad39a4c3c72b03b2436
Author: Yuliya Bozhko <email address hidden>
Date: Tue Dec 9 11:07:02 2014 +1300

Fix page error on form cancel after validation fails (Bug #1400511)

Change-Id: I63c4c566504492abb947202f8cf3ba5838770c9f
Signed-off-by: Yuliya Bozhko <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4076
Committed: http://gitorious.org/mahara/mahara/commit/2bf7c3833b3ad8e0c2a568b37c9f1366b550b215
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.8_STABLE

commit 2bf7c3833b3ad8e0c2a568b37c9f1366b550b215
Author: Yuliya Bozhko <email address hidden>
Date: Tue Dec 9 11:07:02 2014 +1300

Fix page error on form cancel after validation fails (Bug #1400511)

Change-Id: I63c4c566504492abb947202f8cf3ba5838770c9f
Signed-off-by: Yuliya Bozhko <email address hidden>

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers