Need to properly concat lang strings for webservices

Bug #1399446 reported by Robert Lyon on 2014-12-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon

Bug Description

Currently there are places where the text displayed to screen is in the format of:

$html = get_string('stringidentifier') . $variable;

and

$string['stringidentifier'] = 'Example: ';

But that can lead to problems with translations so they need to be:

$html = get_string('stringidentifier', 'section', $variable);

and

$string['stringidentifier'] = 'Example: %s';

Reviewed: https://reviews.mahara.org/4082
Committed: http://gitorious.org/mahara/mahara/commit/71556b3a3dfc969e6bcb98b46ce70b24e1087318
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 71556b3a3dfc969e6bcb98b46ce70b24e1087318
Author: Robert Lyon <email address hidden>
Date: Fri Dec 12 07:56:04 2014 +1300

Properly concat lang strings in webservices (Bug #1399446)

Change-Id: Ib728376b9262bc0bcd45c3f72abba4903dede902
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: Confirmed → Fix Committed
Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers