Textbox/Note config form very slow to load

Bug #1393734 reported by Mike Kelly
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
15.10
Fix Released
Undecided
Unassigned

Bug Description

In a large instance of Mahara, the loading of the textbox config. form is very slow (often over 10 seconds). This seems to be mainly due to the listing of other textboxes, which can be revealed by clicking on the 'Use content from another note' link.

It would be good to load this list as required, rather than every time the textbox config. form is opened.

In addition, the database query to load available textboxes should be optimised or adapted for better perfomance if possible.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Hi Mike,

Do you mean the "Text" or the "Notes"? From "due to the listing of other text boxes" I assume it is the "Notes", but I just want to be sure. And also, in which version of Mahara do you experience this problem?

Thanks
Kristina

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Hi Mike,

To expand on what Kristina said, in Mahara 1.10 we split the old "Text box" block into two new block types: "Text", a lightweight block which only stores non-reusable text, and "Note", which has all the extra functionality of the old "Text box" block -- attachments, reusability, etc.

It sounds like you're talking about the 1.9 Text Box block (which is now the 1.10 Note block)? The Note block is almost exactly the same as the Text Box block, code-wise, so the same issue probably apply there. But, it's mitigated somewhat in 1.10 because:

1. Most Text Box blocks will probably have been converted to Text by the 1.9 -> 1.10 upgrade, so there'll be less of them to cause scaling issues. (The upgrade script converts a Text Box to a Note if it is used in multiple pages or contains attachments, and a Text otherwise.)

2. Users won't be interacting as much with the Note block, since they can now use the Text block for all the simple cases.

Cheers,
Aaron

Revision history for this message
Mike Kelly (m-f-kelly) wrote :

Hi both,

Yes, I'm referring to 1.9 Textbox blocks.
Sounds like the upgrade to 1.10 could solve this then, as long as people don't use the Note feature too much.

I'm a wee bit worried that having two types of block could be confusing, especially as the names don't say anything about the difference between them. That's not relevant to this bug report though.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Okay, I'll move this bug to "Won't Fix" for now. Let me know if you still see problems after upgrading to 1.10. Or if you want to supply a patch, I can also re-open this bug.

summary: - Textbox config form very slow to load
+ Textbox/Note config form very slow to load
Changed in mahara:
status: New → Won't Fix
tags: added: note
tags: added: performance
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3982
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/0a1e5e0e6407f76ee36eeda0732a1e557383d3ba
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0a1e5e0e6407f76ee36eeda0732a1e557383d3ba
Author: Robert Lyon <email address hidden>
Date: Sat May 2 21:36:27 2015 +1200

Lazy-load list of textboxes when opening textbox form (Bug 1393734).

The query to load other textboxes when displaying textbox config. forms
is very heavy in a large instance of Mahara. This patch postpones the
listing of other textboxes in the textbox config. form, until the link
to display them is clicked.
This enables the textbox config. form to load and display quickly.

TODO: optimise loading speed of list of textboxes. This process is still
as slow as it was before - all this patch does is defer it until it's
actually required!

Change-Id: I92c77e22753882a2b9ed5be3738b8d26b7f5709d
Signed-off-by: Mike Kelly <email address hidden>

Revision history for this message
Robert Lyon (robertl-9) wrote :

This was the patch that was added for this problem: https://reviews.mahara.org/#/c/3982/

Changed in mahara:
status: Won't Fix → Fix Committed
milestone: none → 15.10.0
importance: Undecided → Low
importance: Low → Medium
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.