Generate SVG image preview for page layouts

Bug #1392096 reported by Yuliya Bozhko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Yuliya Bozhko

Bug Description

Was just thinking that instead of generating and storing PNG images we could just show <svg> on page directly. Got some proof of concept in review that would need a bit of polishing.

Changed in mahara:
status: New → In Progress
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Hello Yuliya,

Do all the browsers that we support, allow for the <svg> tag or do we need to be careful with certain browsers?

Thank you
Kristina

Revision history for this message
Yuliya Bozhko (yuliya.bozhko) wrote :

All browsers currently supported by Mahara support inline <svg> tag as far as I know.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Yep, SVG is supported in all modern browsers. Even IE9 (and up). Even the mobile browsers! http://caniuse.com/#feat=svg

Changed in mahara:
milestone: none → 15.04.0
Revision history for this message
Aaron Wells (u-aaronw) wrote :

Yuliya pushed a patch for this: https://reviews.mahara.org/#/c/3975/

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Reviewing the code, I now see that it uses inline SVGs, whereas I was thinking of separate svg files. (i.e. the HTML file has an <svg> tag inside of it, and that has some <rect> tags inside it, and so forth)

This is slightly less supported than separate SVG files. But crucially, it's still supported by all our target browsers for Mahara 15.04, including IE9+, so still not a problem. http://caniuse.com/#feat=svg-html5

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3975
Committed: http://gitorious.org/mahara/mahara/commit/4ef75593a2c2bcd248fa2b58532edc9fd5b2a7a2
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 4ef75593a2c2bcd248fa2b58532edc9fd5b2a7a2
Author: Yuliya Bozhko <email address hidden>
Date: Thu Nov 13 11:42:11 2014 +1300

Generate SVG image preview for page layouts (Bug #1392096)

Change-Id: I32faf161d9ef7c9cd020134a08998ce48acc7060
Signed-off-by: Yuliya Bozhko <email address hidden>

tags: added: nominatedfeature
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.