Accepting friend request does not send notification to requester

Bug #1389906 reported by Robert Lyon on 2014-11-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.10
High
Robert Lyon
1.8
High
Robert Lyon
1.9
High
Robert Lyon

Bug Description

In the file lib/user.php there are two functions acceptfriend_submit() and makefriend_submit() that were added by this commit:
647c85495e87acedb3c7e6ac2cac82fcf4ea4d5c

Both create a class of email message info called $n to send an email but only the makefriend_submit() actually sends the email.

Will fix it so both send email, that way friend requester will get the 'Friend request accepted' message.

As this was a bug/oversight way back in 2008 and I'll mark as high and backport to the prev 3 versions as well.

Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/3927

Mahara Bot (dev-mahara) wrote :

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/3928

Mahara Bot (dev-mahara) wrote :

Patch for "1.8_STABLE" branch: https://reviews.mahara.org/3929

Reviewed: https://reviews.mahara.org/3926
Committed: http://gitorious.org/mahara/mahara/commit/dde1201bd5cfffd1e5a641d4cf202d1f2d73d8c9
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit dde1201bd5cfffd1e5a641d4cf202d1f2d73d8c9
Author: Robert Lyon <email address hidden>
Date: Thu Nov 6 12:50:57 2014 +1300

Getting the accept friend to email requestor (Bug #1389906)

This was an oversight from the original commit
647c85495e87acedb3c7e6ac2cac82fcf4ea4d5c

Change-Id: Ie0d5e0306b2cf329574092387ac4c1a233ec2347
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3929
Committed: http://gitorious.org/mahara/mahara/commit/653135c407b5a0ff372e3061e5f4713862b519f1
Submitter: Son Nguyen (<email address hidden>)
Branch: 1.8_STABLE

commit 653135c407b5a0ff372e3061e5f4713862b519f1
Author: Robert Lyon <email address hidden>
Date: Thu Nov 6 12:50:57 2014 +1300

Getting the accept friend to email requestor (Bug #1389906)

This was an oversight from the original commit
647c85495e87acedb3c7e6ac2cac82fcf4ea4d5c

Change-Id: Ie0d5e0306b2cf329574092387ac4c1a233ec2347
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3928
Committed: http://gitorious.org/mahara/mahara/commit/de0c050ee931e06d8df470759292bd66ebc22a6f
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit de0c050ee931e06d8df470759292bd66ebc22a6f
Author: Robert Lyon <email address hidden>
Date: Thu Nov 6 12:50:57 2014 +1300

Getting the accept friend to email requestor (Bug #1389906)

This was an oversight from the original commit
647c85495e87acedb3c7e6ac2cac82fcf4ea4d5c

Change-Id: Ie0d5e0306b2cf329574092387ac4c1a233ec2347
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3927
Committed: http://gitorious.org/mahara/mahara/commit/966b2776619020f6c97dfc3ba5b6e02a00c8c4a1
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 966b2776619020f6c97dfc3ba5b6e02a00c8c4a1
Author: Robert Lyon <email address hidden>
Date: Thu Nov 6 12:50:57 2014 +1300

Getting the accept friend to email requestor (Bug #1389906)

This was an oversight from the original commit
647c85495e87acedb3c7e6ac2cac82fcf4ea4d5c

Change-Id: Ie0d5e0306b2cf329574092387ac4c1a233ec2347
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers