cancel button in sendmessage.php should bring user back to previous page

Bug #1387511 reported by Dirk Meyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Aaron Wells

Bug Description

After clicking the 'Compose' tab as discussed in bug 1385412 https://bugs.launchpad.net/mahara/+bug/1385412 and then clicking 'cancel' the user is re-directed to user/myfriends.php

I believe it would be an inprovement if the user would be directed back to the inbox after clicking cancel. I think cancel buttons usually return to the previous page. Doing so would be consistent with behavior of the cancel button when the user clicks 'send message' to a particular users in htdocs/user/find.php

To achiev emy proposal, the following works for me:

line 165 /htdocs/artefact/multirecipientnotification/sendmessage.php

$goto = 'user/myfriends.php'; to $goto = 'artefact/multirecipientnotification/inbox.php';

Revision history for this message
Aaron Wells (u-aaronw) wrote :

The same thing happens with the "send" button as well, actually.

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Hm, I think the reason it sends you back to "My friends" is because (before we added the "Compose" button) you initiated a message send by clicking on "Send message" on a user profile page. But, since it may contain multiple recipients, it didn't make sense to send you back to just one of their profile pages, so it sends you to the Friends list instead.

But you know... I think maybe the most logical place to send you, would be to the "Sent messages" page. So that you can get a visual confirmation that your message was sent.

Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Aaron Wells (u-aaronw)
milestone: none → 15.04.0
tags: added: messaging usability
Changed in mahara:
importance: Medium → Wishlist
importance: Wishlist → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3890

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3890
Committed: http://gitorious.org/mahara/mahara/commit/3276abeb632cd882fdec627b18cfa870e95ded90
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3276abeb632cd882fdec627b18cfa870e95ded90
Author: Aaron Wells <email address hidden>
Date: Fri Oct 31 13:22:46 2014 +1300

Make the message "Compose" button return you to the "Sent messages" screen

Bug 1387511: Also making the "Sent messages" screen into the default return
screen regardless of how you got to the Compose screen.

Change-Id: Ifa3d48fa4cc1cd15a6ae3218915f336216cc6473

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.