Missing title tag on file unzip button

Bug #1386970 reported by Aaron Wells on 2014-10-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Aaron Wells
1.10
Medium
Aaron Wells
1.9
Medium
Aaron Wells
15.04
Medium
Aaron Wells

Bug Description

The alt text for the "unzip", "edit", and "delete" buttons in the Content -> Files are, contains unescaped double quotes.

<img alt="Decompress "3077-1316797096-PVE.zip"" src="http://vegas.wgtn.cat-it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

These should be escaped into HTML entities (by being passed through htmlspecialchars()/hsc())

<img alt="Decompress &quot;3077-1316797096-PVE.zip&quot;" src="http://vegas.wgtn.cat-it.co.nz/mahara/htdocs/theme/raw/static/images/btn_extract.png">

This breaks the alt tag, and it also causes problems for our Behat testers because without the alt tag there's no way to uniquely identify one of these.

Aaron Wells (u-aaronw) wrote :

Never mind, it turns out the alt tag is fine! It's just the Firefox Web Developer tools display &quot; as " when you're using the source inspect tool.

But when I do "view source" outside of the web developer tools, I do see &quot;.

However, that button is still missing a title tag.

summary: - Broken alt tag (and missing title tag) on file unzip, edit, delete
- buttons
+ Missing title tag on file unzip button

Reviewed: https://reviews.mahara.org/3877
Committed: http://gitorious.org/mahara/mahara/commit/5b753c08e330a0516016f04bc5dd52b22177a2b0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5b753c08e330a0516016f04bc5dd52b22177a2b0
Author: Aaron Wells <email address hidden>
Date: Wed Oct 29 16:52:28 2014 +1300

Adding a title tag to the "unzip" button

Bug 1386970

Change-Id: Id2f5da4a4d1fabf77dbb73fc112d93ef353b6584

Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/3879

Reviewed: https://reviews.mahara.org/3878
Committed: http://gitorious.org/mahara/mahara/commit/d3b98e0e294c9072dfc18407947d2e5c5650f63a
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit d3b98e0e294c9072dfc18407947d2e5c5650f63a
Author: Aaron Wells <email address hidden>
Date: Wed Oct 29 16:52:28 2014 +1300

Adding a title tag to the "unzip" button

Bug 1386970

Change-Id: Id2f5da4a4d1fabf77dbb73fc112d93ef353b6584

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3879
Committed: http://gitorious.org/mahara/mahara/commit/e9cade24c148358c2e4772cc29317c1ba4dbe586
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit e9cade24c148358c2e4772cc29317c1ba4dbe586
Author: Aaron Wells <email address hidden>
Date: Wed Oct 29 16:52:28 2014 +1300

Adding a title tag to the "unzip" button

Bug 1386970

Change-Id: Id2f5da4a4d1fabf77dbb73fc112d93ef353b6584

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers