The js script 'artefact/multirecipientnotification/js/sendmessage.js' is not neccessary

Bug #1383543 reported by Son Nguyen on 2014-10-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Tobias Zeuch
1.10
Low
Unassigned
15.04
Low
Unassigned
15.10
Low
Tobias Zeuch

Bug Description

Version: master, 1.10

It looks like the js script 'artefact/multirecipientnotification/js/sendmessage.js' is redundant.
When I remove it from the code, the feature still works

Robert Lyon (robertl-9) wrote :

Ah, I was suspecting that when I was reviewing a patch but then forgot to double check with Tobias about it

Tobias,

Do you want to take a look at this?

Cheers
Kristina

Tobias Zeuch (tobias-zeuch-8) wrote :

Sorry, I had kept the mail from launchpad to have a look it some other time but until now I hadn't opened the bug.
Seems like sendmessage.js is a remnant from before we/I integrated the autocomplete box. I'll check again to make sure but I think you're right and it can be deleted.

Reviewed: https://reviews.mahara.org/4994
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/9dfa43c7c6876a8c48ed140c9c48821d81a52635
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 9dfa43c7c6876a8c48ed140c9c48821d81a52635
Author: Tobias Zeuch <email address hidden>
Date: Mon Jul 20 22:01:08 2015 +0200

Bug 1383543: script multirecipientnotification/js/sendmessage.js is redundant

I had used the script in the first patches for the new plugin but it got
obsolete when I changed the recipients list to be rendered with the
autocomplete box

Change-Id: Ied74b0cefbaae91fdcb4c9f99420c0f96a433500
Signed-off-by: Tobias Zeuch <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/5129

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/5136

Reviewed: https://reviews.mahara.org/5129
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/2ea1a4526d5759e264cfa2921144f6b5ab8b6dd7
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 2ea1a4526d5759e264cfa2921144f6b5ab8b6dd7
Author: Tobias Zeuch <email address hidden>
Date: Mon Jul 20 22:01:08 2015 +0200

Bug 1383543: script multirecipientnotification/js/sendmessage.js is redundant

I had used the script in the first patches for the new plugin but it got
obsolete when I changed the recipients list to be rendered with the
autocomplete box

Change-Id: Ied74b0cefbaae91fdcb4c9f99420c0f96a433500
Signed-off-by: Tobias Zeuch <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5117
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/83b8ac1a6571ca443adac2543844b019ec0fc415
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 83b8ac1a6571ca443adac2543844b019ec0fc415
Author: Tobias Zeuch <email address hidden>
Date: Mon Jul 20 22:01:08 2015 +0200

Bug 1383543: script multirecipientnotification/js/sendmessage.js is redundant

I had used the script in the first patches for the new plugin but it got
obsolete when I changed the recipients list to be rendered with the
autocomplete box

Change-Id: Ied74b0cefbaae91fdcb4c9f99420c0f96a433500
Signed-off-by: Tobias Zeuch <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/5136
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/49412a2bf920d8ec43d7aaa1070eb83485481c7d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 49412a2bf920d8ec43d7aaa1070eb83485481c7d
Author: Robert Lyon <email address hidden>
Date: Tue Aug 18 12:26:37 2015 +1200

Bug 1383543: script multirecipientnotification/js/sendmessage.js is redundant

I had used the script in the first patches for the new plugin but it got
obsolete when I changed the recipients list to be rendered with the
autocomplete box

Change-Id: Ic3abfb06f29708097134d2ab2efed4397ad01b8e
Signed-off-by: Tobias Zeuch <email address hidden>

Robert Lyon (robertl-9) on 2016-11-06
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers