Profile -> contact information -> address textarea not displaying correctly

Bug #1382159 reported by Robert Lyon on 2014-10-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.10
High
Robert Lyon
15.04
High
Unassigned

Bug Description

For some reason, which I'm about to look into, the textarea is given a height of 1px and width of 0 via css - so it doesn't display correctly.

Aaron Wells (u-aaronw) wrote :

Git bisect indicates this was the change that caused this regression: https://reviews.mahara.org/#/c/3481/

Reviewed: https://reviews.mahara.org/3821
Committed: http://gitorious.org/mahara/mahara/commit/700340fef30f72662d85b7af0731bdfde5ac8e3e
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 700340fef30f72662d85b7af0731bdfde5ac8e3e
Author: Robert Lyon <email address hidden>
Date: Fri Oct 17 09:12:52 2014 +1300

Finding the dimensions of hidden textareas (Bug #1382159)

If the parents of a textarea are also hidden it returns height/width
as 0, which is no use to us. So we need to find it's height/width when
not hidden.

So added some code to:
- to clone the textarea
- make it positioned way outside the viewport
- append it to body
- find height/width
- remove the clone from body
- return the height/width

Change-Id: Ib2fa2d80b3046909ed2763545410d5d95f464b4d
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3823
Committed: http://gitorious.org/mahara/mahara/commit/447a16280b4a94972d1b79f4dcd1394e6b6201fd
Submitter: Aaron Wells (<email address hidden>)
Branch: 1.10_STABLE

commit 447a16280b4a94972d1b79f4dcd1394e6b6201fd
Author: Robert Lyon <email address hidden>
Date: Fri Oct 17 09:12:52 2014 +1300

Finding the dimensions of hidden textareas (Bug #1382159)

If the parents of a textarea are also hidden it returns height/width
as 0, which is no use to us. So we need to find it's height/width when
not hidden.

So added some code to:
- to clone the textarea
- make it positioned way outside the viewport
- append it to body
- find height/width
- remove the clone from body
- return the height/width

Change-Id: Ib2fa2d80b3046909ed2763545410d5d95f464b4d
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers