external media not returning an error for bad non url input

Bug #1381807 reported by Robert Lyon on 2014-10-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Robert Lyon

Bug Description

Need additional check so that inputs that fail the url check should be checked for tag structure

So to test:

Should pass:

- http://youtu.be/vDy3NXVBQtI
- <iframe width="560" height="349" src="http://www.youtube.com/embed/vDy3NXVBQtI" frameborder=0></iframe>

Should fail:
- blahblah (random text)
- <iframe width="560" height="349" src="http://www.yo (incomplete tag structure)
-

Reviewed: https://reviews.mahara.org/3807
Committed: http://gitorious.org/mahara/mahara/commit/ca009175b38c97c39be8abdf247c989de7111b79
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit ca009175b38c97c39be8abdf247c989de7111b79
Author: Robert Lyon <email address hidden>
Date: Thu Oct 16 11:45:46 2014 +1300

Add validation error for non url input (Bug #1381807)

Change-Id: I743d481c7775079c807e4e93b4bba4d39ceeb61d
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2014-10-27
Changed in mahara:
status: Confirmed → Fix Committed
Aaron Wells (u-aaronw) wrote :

I don't think we're planning on backporting this one at the moment, but if anyone does backport it in the future, be aware that it introduced a regression: https://bugs.launchpad.net/mahara/+bug/1421444

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers