Journal entry TinyMCE missing row toggle button

Bug #1381738 reported by Dirk Meyer on 2014-10-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Aaron Wells
1.10
High
Aaron Wells
15.04
High
Aaron Wells

Bug Description

1.10rc1

I can neither widen the text area nor can I work in full screen mode anymore. It being a journal page, the software should try to provide the best text creation/editing environment possible.

Dirk Meyer (dirkca68) wrote :
Aaron Wells (u-aaronw) on 2014-10-16
summary: - Journal entry
+ Journal entry TinyMCE missing "tool toggle" button
summary: - Journal entry TinyMCE missing "tool toggle" button
+ Journal entry TinyMCE missing functionality
Changed in mahara:
status: New → Confirmed
status: Confirmed → In Progress
importance: Undecided → High
assignee: nobody → Aaron Wells (u-aaronw)
tags: added: blog
tags: added: tinymce usability
Aaron Wells (u-aaronw) wrote :

Oh, actually Mahara has never supported the ability to widen a TinyMCE area. I was just checking Mahara 1.9 & 1.8, and in those you can't expand them vertically either, so that appears to be something we've added in Mahara 1.10.

Well, I've pushed a patch to add the toggle button back in, which will make it possible to take the journal entry text field to full-screen.

summary: - Journal entry TinyMCE missing functionality
+ Journal entry TinyMCE missing row toggle button
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/3820

Reviewed: https://reviews.mahara.org/3820
Committed: http://gitorious.org/mahara/mahara/commit/886a7463566acb75dece77f46a253462ef3a40b5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 886a7463566acb75dece77f46a253462ef3a40b5
Author: Aaron Wells <email address hidden>
Date: Thu Oct 16 19:20:56 2014 +1300

Restore "toggle" button to TinyMCEs with "tinymceconfig" param

Bug 1381738. All the TinyMCE instances that use the "maharaimage" plugin are providing
their own tinymceconfig param which redefines the whole list of plugins in use. So they
didn't get the message when "tooltoggle" became one of the standard plugins.

This fix is a bit of a hack. A more robust fix would provide a way for a TinyMCE to
*add* to the list of plugins, or just specifically say it wants to use maharaimage
instead of image.

Change-Id: Ia8128e5d70bd4be1e5d4b45efae368a88174c4c5

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/3818
Committed: http://gitorious.org/mahara/mahara/commit/849772c9aeb791649e11186946f4f99b543612d5
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 849772c9aeb791649e11186946f4f99b543612d5
Author: Aaron Wells <email address hidden>
Date: Thu Oct 16 19:20:56 2014 +1300

Restore "toggle" button to TinyMCEs with "tinymceconfig" param

Bug 1381738. All the TinyMCE instances that use the "maharaimage" plugin are providing
their own tinymceconfig param which redefines the whole list of plugins in use. So they
didn't get the message when "tooltoggle" became one of the standard plugins.

This fix is a bit of a hack. A more robust fix would provide a way for a TinyMCE to
*add* to the list of plugins, or just specifically say it wants to use maharaimage
instead of image.

Change-Id: Ia8128e5d70bd4be1e5d4b45efae368a88174c4c5

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers