need to drop old default email option

Bug #1381184 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Unassigned

Bug Description

Now that we use individual default email options for each activity type we need a patch to remove the 'defaultnotificationmethod' from config table.

But the problem is we can't add it to the lib/db/upgrade.php as that is run before the upgrade on plugins - nor can we put it in the postinst of a plugin because we don't know which plugins will need to be updated last post 1.9 - eg if we go from 1.9 -> 1.10 or even 1.9 -> 1.15 we will need to know the old defaultmethod. But after the initial jump we will not need to know about it.

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 15.04.0 → 15.04.1
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 15.04.1 → 15.10.0
Aaron Wells (u-aaronw)
no longer affects: mahara/15.10
Changed in mahara:
importance: Medium → Low
no longer affects: mahara/15.10
no longer affects: mahara/16.04
Changed in mahara:
milestone: 15.10.1 → 16.10.0
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.0 → 16.10.1
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.1 → 17.04.0
Changed in mahara:
milestone: 17.04.0 → 17.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8028

Revision history for this message
Robert Lyon (robertl-9) wrote :

Can fix this easily now as we recommend upgrading to 15.04 from older sites before upgrading to 17.10+

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8028
Committed: https://git.mahara.org/mahara/mahara/commit/1238a95bd696204a259afcea728582481c534eca
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1238a95bd696204a259afcea728582481c534eca
Author: Robert Lyon <email address hidden>
Date: Tue Sep 19 12:25:21 2017 +1200

Bug 1381184: Removing obsolete config value

This value would be present in < 1.10 versions

behatnotneeded

Change-Id: Ic92beea1a209580f798716227a7c53fb600a8869
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.