Giving access to 2 pages only generates 1 access notification
Bug #1380203 reported by
Kristina Hoeppner
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Robert Lyon | ||
1.10 |
Fix Released
|
High
|
Robert Lyon | ||
15.04 |
Fix Released
|
High
|
Robert Lyon |
Bug Description
1.10RC1 (but probably general issue)
Test case:
1. User A is friends with user B.
2. User A shares two separate pages, Page 1 and Page 2 (i.e. they aren't in a collection) with "Friends".
3. User B receives a "New page access" notification for Page 1 but not for Page 2. Since the 2 pages are not in a collection, user B doesn't know that she actually also has access to that other page.
Access notifications for separate pages should always list all pages to which the user has access to.
Changed in mahara: | |
assignee: | nobody → Robert Lyon (robertl-9) |
milestone: | none → 1.11.0 |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Ok what happens is that when one updates the view access for a bunch of pages at once the update_ view_access( ) function goes and sets the new access for the first item via set_access() and then duplicates those access rules for the others with copy_access().
The problem is the set_access() triggers the activity notification and copy_access() does not so only the first item get notified for.
What is needed is to be able to trigger the notify for each item.
What would be good would be to ignore the notification trigger in the set_access() if we have more than one item to notify for and instead do a notify with message that includes all items we are dealing with.