"System messages" and "Messages from other users" can be set to "None"

Bug #1380200 reported by Kristina Hoeppner on 2014-10-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
1.10
High
Robert Lyon
15.04
High
Unassigned

Bug Description

1.10RC1 (new feature in 1.10)

The report at bug #1299993 says that system messages and messages from other users should not be able to be set to "None" and Steven confirmed that in his testing. However, when I look at it for the user manual, I can set those two notification types to "None" in both the "Notification settings (Config site -> Site options) and also under Settings -> Notifications.

P.S. I'm on an upgraded Mahara

the problem does not exist on a fresh install

Robert Lyon (robertl-9) wrote :

To test:

1) Install a previous version of mahara (say 1.9)
2) Checkout latest master and upgrade the mahara
3) Change the notification setting for a user and/or the site you can now set 'System message' and 'Message from other users' to 'none' - this should not be allowed
4) Check out patch - it should prompt you to upgrade
5) Try to change the notification setting for a user and/or the site you should not be allowed to choose 'none' for 'System message' and 'Message from other users'

Robert Lyon (robertl-9) on 2014-10-12
Changed in mahara:
status: Confirmed → In Progress
Eduardo (o-eduardo) wrote :

Tested on Mahara version 1.11.0dev (2014101300) with a previous installed version (1.9.3testing). Here are my testing method:

1. Installed a previous version of Mahara (1.9.3testing)
2. Log in as admin
3. Go to Administration
4. Go to “Users” → Create user Bob
5. Log out
6. git checkout patch
7. Log in as admin
8. Go to Administration
9. Configure Site → Notification settings
10. Confirm that System message & Message from other users cannot be set to “None” → Passed
11.Go to Users → Create user Jen
12. Log in as Jen
13. Go to Settings → Notification settings
14. Confirm that System message & Message from other users cannot be set to “None” → Passed
15. Log out as “Jen”
16. Log in as “Bob” (created on 1.9.3testing)
17. Go to Settings → Notifications settings
18. Confirm that System message & Message from other users cannot be set to “None” → Passed

Reviewed: https://reviews.mahara.org/3788
Committed: http://gitorious.org/mahara/mahara/commit/47ee961e8245158339e65c3442bbc50f3b875f82
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 47ee961e8245158339e65c3442bbc50f3b875f82
Author: Robert Lyon <email address hidden>
Date: Mon Oct 13 08:55:51 2014 +1300

Making sure core message notifications are correct on upgrade

Bug 1380200 - make sure main two do not have 'none' option
Bug 1380829 - make sure the previous default email method is respected

On upgrade from 1.9 the default core notifications 'System message'
and 'Message from other users' can be set to 'none' - which is not
allowed.

This patch will fix that problem by making sure the default core
notifications are set to email and that any users are also updated to
beusing the newly set default method.

Also deals with setting the default email method correctly - the prev
change to notifications didn't set the default email method with the
correct currently being used method.

Change-Id: I98dcc8374876e20cb5c2952121b69dab99c7cf19
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/3805
Committed: http://gitorious.org/mahara/mahara/commit/c9aefd3c1c571f698d52c9080327cc04c7743d78
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit c9aefd3c1c571f698d52c9080327cc04c7743d78
Author: Robert Lyon <email address hidden>
Date: Mon Oct 13 08:55:51 2014 +1300

Making sure core message notifications are correct on upgrade

Bug 1380200 - make sure main two do not have 'none' option
Bug 1380829 - make sure the previous default email method is respected

On upgrade from 1.9 the default core notifications 'System message'
and 'Message from other users' can be set to 'none' - which is not
allowed.

This patch will fix that problem by making sure the default core
notifications are set to email and that any users are also updated to
beusing the newly set default method.

Also deals with setting the default email method correctly - the prev
change to notifications didn't set the default email method with the
correct currently being used method.

Change-Id: I98dcc8374876e20cb5c2952121b69dab99c7cf19
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2015-04-17
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers