Skins folder on upload of background images - multiple images attached to skins

Bug #1378176 reported by Teresa Brady on 2014-10-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Unassigned

Bug Description

A feature request, although not exactly sure if a bug/issue
If a skin is deleted, and a skin is re-imported, the background images are also re-imported.
This can be visually confusing for users (see attached image: multiple_copies_images.png) as it creates multiple copies of the same image. I know the image files have unique background identifiers, its just that many users will get confused, especially if they are learning to use skins and go to delete a file and accidentally delete the one their skin is using.
Is it possible to have a folder automatically created on upload of an image called 'page-skins' for background image purposes?
Or have it so that it recognises the image is already there, maybe?

Teresa Brady (tess-brady) wrote :
Aaron Wells (u-aaronw) wrote :

That would probably be a good idea.

tags: added: skins
Changed in mahara:
importance: Undecided → Medium
status: New → Confirmed
tags: added: usability
Robert Lyon (robertl-9) wrote :

At the very least the adding of the image should have appendix added to it like what happens when we upload a file on the Content -> Files page

eg if I upload a file called badger.jpg more than once I get

badger.jpg
badger.jpg.1
badger.jpg.2
badger.jpg.3

So they are named visually different.

Currently there is the warning about deleting a file that is used in a skin "This file is used as a background image in one or more of your skins. Are you sure you want to delete this file?" so people shouldn't be able to delete an image from a skin by accident

Jono Mingard (mingard) wrote :

What happens if two skins include a file called background.png? Deleting the image if it exists wouldn't be so good if that's a possible scenario ...
I do think it's a bit confusing to add images to the root directory, particularly if they have quite generic names. If skins are likely to be able to contain more images in the future it might even make sense to store them in "page-skins/skin-name/..."

On a related note, should there be an option to delete all associated images when you delete a skin? For example if you're trying out various different skins from the internet and deleting the ones you don't want, it would be annoying to have to go through and delete all the related images as well.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers