Mahara

"Shared with" on "Shared with me" is not displayed at beginning of the line

Bug #1377556 reported by Kristina Hoeppner on 2014-10-05

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Mahara	Fix Released	High	Robert Lyon	Mahara 1.10.0

Bug Description

1.10RC1

The string "Shared with me" does not sit underneath "Sort results by" anymore and has lost its bold letters. See attached screenshot.

Tags:

Revision history for this message

Kristina Hoeppner (kris-hoeppner) wrote on 2014-10-05:

110_bug_sharedwith.png Edit (29.8 KiB, image/png)

Robert Lyon (robertl-9) on 2014-10-05

Changed in mahara:
status:	Confirmed → In Progress
assignee:	nobody → Robert Lyon (robertl-9)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2014-10-05: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3747

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2014-10-08: A change has been merged

Reviewed: https://reviews.mahara.org/3747
Committed: http://gitorious.org/mahara/mahara/commit/5fdae924355513fe7f1927a74cd515707cd6391d
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 5fdae924355513fe7f1927a74cd515707cd6391d
Author: Robert Lyon <email address hidden>
Date: Mon Oct 6 11:54:43 2014 +1300

Need to add no label title alternative tag (Bug #1377556)

Seen as we removed the orphaned labels we need to add back a <span
class="pseudolabel"> so that we can add css to make it visually behave
like a label without causing accessibility problems

Change-Id: I6cc5fc419e436b8c466900ed7b55541b0a0aca56
Signed-off-by: Robert Lyon <email address hidden>

Son Nguyen (ngson2000) on 2014-10-08

Changed in mahara:
status:	In Progress → Fix Committed

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2014-10-09: A patch has been submitted for review

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/3781

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2014-10-09: A change has been merged

Reviewed: https://reviews.mahara.org/3781
Committed: http://gitorious.org/mahara/mahara/commit/348691dcc60190c844ca48d1fc5109effa908c64
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit 348691dcc60190c844ca48d1fc5109effa908c64
Author: Robert Lyon <email address hidden>
Date: Mon Oct 6 11:54:43 2014 +1300

Need to add no label title alternative tag (Bug #1377556)

Seen as we removed the orphaned labels we need to add back a <span
class="pseudolabel"> so that we can add css to make it visually behave
like a label without causing accessibility problems

Change-Id: I6cc5fc419e436b8c466900ed7b55541b0a0aca56
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw) on 2014-10-21