There shouldn't be a notification for gaining access to a group homepage

Bug #1377543 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
1.10
Fix Released
High
Robert Lyon
15.04
Fix Released
High
Robert Lyon

Bug Description

1.10RC1

When you become a member of a group, you receive a notification for having access to "Group homepage". This should not happen.

If a user is to be notified of having access to a group, it should be something like 'You are now a member of the group "XYZ".' but not for having access to the group homepage. The group homepage is essentially the group itself.

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/3749

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Son Nguyen (ngson2000) wrote :

Hi Kristina,

How can you enable an user to be notified of having access to a group?

Thanks

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Normally, people are not notified when they join a group or are added to it. However, they can receive a notification. While testing the RC, I did get a notification for having access to the group homepage and thus I had created this bug report.

Please be a bit more specific if that doesn't answer your questions.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

To test:

1. Pull master code (I used Mahara version 1.11.0dev (2014092500))
2. Log in as admin.
3. Set up a group. I had chosen an open group with no other special settings, but made sure that all members of the group would be notified of shared pages.
4. Save the group settings.
5. You will get a notification about access to the group homepage. You may need to run the cron manually if it is not running automatically. Otherwise, the notification will not be sent.

Apply the patch and follow the instructions again. You don't get the notification about the group homepage anymore.

Revision history for this message
Eduardo (o-eduardo) wrote :

Before Patch admin was receiving a notification on gaining access to "Group homepage". After patch there was no notification. Below are my steps:

1. Pull master code ( I also used Mahara version 1.11.0dev ( 2014092500))
2. Logged in as admin.
3. Created an Open group called: "Testing Bug". With all default setting, so no changes made
4. Save the group settings.
5. Run Cron manually
5. And I also received the email:
  "subject: New access to page "Group homepage"
 You have been added to the access list for the page "Group homepage" by Testing
 bug"

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3749
Committed: http://gitorious.org/mahara/mahara/commit/9f7c336e26e1e0a22acc989b227c8b979be8b016
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 9f7c336e26e1e0a22acc989b227c8b979be8b016
Author: Robert Lyon <email address hidden>
Date: Mon Oct 6 14:57:28 2014 +1300

Do not do viewaccess notification for group homepage (Bug #1377543)

Change-Id: I8cee490dc41c449bd878e7675dd2b6f44e02c0b7
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/3784

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/3784
Committed: http://gitorious.org/mahara/mahara/commit/b112c0e18ef72fa8d5ffcaf7b1e734ffc9a8afd6
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit b112c0e18ef72fa8d5ffcaf7b1e734ffc9a8afd6
Author: Robert Lyon <email address hidden>
Date: Mon Oct 6 14:57:28 2014 +1300

Do not do viewaccess notification for group homepage (Bug #1377543)

Change-Id: I8cee490dc41c449bd878e7675dd2b6f44e02c0b7
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.